Fix parallelization issue with rule synthsr#79
Merged
Dhananjhay merged 2 commits intomainfrom Jun 18, 2025
Merged
Conversation
Member
|
Tested this PR via jclauneurolab container on CBS and its good to merge from my end! |
ataha24
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #74.
Dynamically setting the number of threads for the synthsr rule, as done previously, was not appropriate. After monitoring resource usage, it’s more reasonable to fix the number of threads at 4 while keeping the memory limit unchanged. I’ve tested these adjustments using the container setup on both CBS-basic and CBS-heavy systems.