Skip to content

Update PrefCoroutines.kt#9

Open
glovebx wants to merge 1 commit into
afollestad:masterfrom
glovebx:patch-1
Open

Update PrefCoroutines.kt#9
glovebx wants to merge 1 commit into
afollestad:masterfrom
glovebx:patch-1

Conversation

@glovebx
Copy link
Copy Markdown

@glovebx glovebx commented Jan 29, 2021

seems destroy() was not invoked properly. onChanged array in RealPref.kt remains old listener(s) will cause JobCancellationException, For example when fragment created again

Guidelines

  1. You must run the spotlessApply task before commiting, either through Android Studio or with ./gradlew spotlessApply.
  2. A PR should be focused and contained. If you are changing multiple unrelated things, they should be in separate PRs.
  3. A PR should fix a bug or solve a problem - something that only you would use is not necessarily something that should be published.
  4. Give your PR a detailed title and description - look over your code one last time before actually creating the PR. Give it a self-review.

If you do not follow the guidelines, your PR will be rejected.

seems destroy() was not invoked properly. onChanged array in RealPref.kt remains old listener(s) will cause JobCancellationException, For example when fragment created again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant