-
Notifications
You must be signed in to change notification settings - Fork 18
feat(retrieval): Calibrate strict-recall threshold, add filter_score config, pass through min_score via MCP/hook, and add full evaluation report #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ch-qiaoyongheng
wants to merge
12
commits into
afx-team:main
Choose a base branch
from
ch-qiaoyongheng:feat/issue-31-recall-floor-configurable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8da7bab
feat(console): add rerank_floor_ratio to the web settings UI
ch-qiaoyongheng a710fa6
feat(retrieval): make rerank_floor_ratio configurable, add min_score …
ch-qiaoyongheng c6b3e20
eval(retrieval): add strict-recall threshold calibration probe and fu…
ch-qiaoyongheng 9c2f1d7
eval(retrieval): add strict-recall threshold calibration probe and fu…
ch-qiaoyongheng dae4901
fix(models): add pre_rerank_score field to fix mypy attr-defined + up…
ch-qiaoyongheng e9b88d6
Merge remote-tracking branch 'origin/feat/issue-31-recall-floor-confi…
ch-qiaoyongheng e878612
fix(eval,retrieval): fix 4 bugs found in review
ch-qiaoyongheng 7318a57
fix(eval,retrieval,frontend): fix 4 bugs + frontend validation + rep…
ch-qiaoyongheng 77bec46
feat(retrieval): refactor retrieval filtering, use composite score in…
ch-qiaoyongheng a7a2574
fix(retrieval): fix filter_score using wrong score field + improve ro…
ch-qiaoyongheng c804158
fix(docs): correct R@10 figures and update deprecated field references
ch-qiaoyongheng f1cd11a
fix(config,eval): fix deprecated field annotations and eval report data
ch-qiaoyongheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
183 changes: 183 additions & 0 deletions
183
eval/reports/threshold_calibration/full-A_composite_baseline.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,183 @@ | ||
| { | ||
| "config": { | ||
| "dataset": "locomo", | ||
| "reranker": "none", | ||
| "top_n": 0, | ||
| "top_k": 10, | ||
| "vector": false, | ||
| "min_score_range": "0.5,0.95,0.05", | ||
| "rerank_floor_ratio_range": "N/A" | ||
| }, | ||
| "score_distributions": { | ||
| "sigmoid_pool": { | ||
| "n": 0, | ||
| "mean": 0, | ||
| "p10": 0, | ||
| "p50": 0, | ||
| "p90": 0, | ||
| "min": 0, | ||
| "max": 0 | ||
| }, | ||
| "composite_tail": { | ||
| "n": 19766, | ||
| "mean": 0.6747, | ||
| "p10": 0.4236, | ||
| "p50": 0.6942, | ||
| "p90": 0.8825, | ||
| "min": 0.0, | ||
| "max": 1.0 | ||
| }, | ||
| "relevant_sigmoid": { | ||
| "n": 0, | ||
| "mean": 0, | ||
| "p10": 0, | ||
| "p50": 0, | ||
| "p90": 0, | ||
| "min": 0, | ||
| "max": 0 | ||
| }, | ||
| "irrelevant_sigmoid": { | ||
| "n": 0, | ||
| "mean": 0, | ||
| "p10": 0, | ||
| "p50": 0, | ||
| "p90": 0, | ||
| "min": 0, | ||
| "max": 0 | ||
| } | ||
| }, | ||
| "baseline": { | ||
| "R@1": 0.6799797775530839, | ||
| "R@3": 0.8185035389282103, | ||
| "R@5": 0.8675429726996967, | ||
| "R@10": 0.9150657229524772 | ||
| }, | ||
| "sweep_results": [ | ||
| { | ||
| "min_score": 0.5, | ||
| "ratio": 1.0, | ||
| "floor": 0.5, | ||
| "R@1": 0.681, | ||
| "R@3": 0.8175, | ||
| "R@5": 0.8691, | ||
| "R@10": 0.9044, | ||
| "empty_frac": 0.0025, | ||
| "mean_results": 8.51 | ||
| }, | ||
| { | ||
| "min_score": 0.55, | ||
| "ratio": 1.0, | ||
| "floor": 0.55, | ||
| "R@1": 0.681, | ||
| "R@3": 0.8175, | ||
| "R@5": 0.8645, | ||
| "R@10": 0.9004, | ||
| "empty_frac": 0.0051, | ||
| "mean_results": 8.05 | ||
| }, | ||
| { | ||
| "min_score": 0.6, | ||
| "ratio": 1.0, | ||
| "floor": 0.6, | ||
| "R@1": 0.6825, | ||
| "R@3": 0.8165, | ||
| "R@5": 0.8595, | ||
| "R@10": 0.8903, | ||
| "empty_frac": 0.0096, | ||
| "mean_results": 7.28 | ||
| }, | ||
| { | ||
| "min_score": 0.65, | ||
| "ratio": 1.0, | ||
| "floor": 0.65, | ||
| "R@1": 0.6734, | ||
| "R@3": 0.8013, | ||
| "R@5": 0.8362, | ||
| "R@10": 0.8595, | ||
| "empty_frac": 0.0273, | ||
| "mean_results": 6.16 | ||
| }, | ||
| { | ||
| "min_score": 0.7, | ||
| "ratio": 1.0, | ||
| "floor": 0.7, | ||
| "R@1": 0.6608, | ||
| "R@3": 0.7685, | ||
| "R@5": 0.7952, | ||
| "R@10": 0.8124, | ||
| "empty_frac": 0.0652, | ||
| "mean_results": 4.84 | ||
| }, | ||
| { | ||
| "min_score": 0.75, | ||
| "ratio": 1.0, | ||
| "floor": 0.75, | ||
| "R@1": 0.6223, | ||
| "R@3": 0.7073, | ||
| "R@5": 0.7275, | ||
| "R@10": 0.7376, | ||
| "empty_frac": 0.1496, | ||
| "mean_results": 3.56 | ||
| }, | ||
| { | ||
| "min_score": 0.8, | ||
| "ratio": 1.0, | ||
| "floor": 0.8, | ||
| "R@1": 0.5536, | ||
| "R@3": 0.6158, | ||
| "R@5": 0.6289, | ||
| "R@10": 0.6355, | ||
| "empty_frac": 0.2755, | ||
| "mean_results": 2.36 | ||
| }, | ||
| { | ||
| "min_score": 0.85, | ||
| "ratio": 1.0, | ||
| "floor": 0.85, | ||
| "R@1": 0.4429, | ||
| "R@3": 0.4808, | ||
| "R@5": 0.4884, | ||
| "R@10": 0.4909, | ||
| "empty_frac": 0.4403, | ||
| "mean_results": 1.44 | ||
| }, | ||
| { | ||
| "min_score": 0.9, | ||
| "ratio": 1.0, | ||
| "floor": 0.9, | ||
| "R@1": 0.3306, | ||
| "R@3": 0.3519, | ||
| "R@5": 0.3549, | ||
| "R@10": 0.3554, | ||
| "empty_frac": 0.6006, | ||
| "mean_results": 0.83 | ||
| }, | ||
| { | ||
| "min_score": 0.95, | ||
| "ratio": 1.0, | ||
| "floor": 0.95, | ||
| "R@1": 0.2275, | ||
| "R@3": 0.2427, | ||
| "R@5": 0.2452, | ||
| "R@10": 0.2457, | ||
| "empty_frac": 0.724, | ||
| "mean_results": 0.56 | ||
| } | ||
| ], | ||
| "recommendation": { | ||
| "strategy": "primary", | ||
| "min_score": 0.5, | ||
| "ratio": 1.0, | ||
| "R@10": 0.9044489383215369, | ||
| "empty_frac": 0.0025278058645096056 | ||
| }, | ||
| "current_default": { | ||
| "min_score": 0.8, | ||
| "ratio": 0.625, | ||
| "R@1": null, | ||
| "R@3": null, | ||
| "R@5": null, | ||
| "R@10": null, | ||
| "empty_frac": null | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
This artifact does not match the probe's current output format.
main_asyncnow always writesfloor_modeintoconfig, but lines 2-10 have nofloor_modekey. Lines 174-182 record"ratio": 0.625with every metricnull, while the composite branch of the current code passescurrent_ratio=1.0and would resolve themin_score0.8 cell (R@1 0.5536, R@10 0.6355, empty_frac 0.2755). Regenerate this report with the current probe so the committed evidence matches the tool and the current-default row carries values.Also applies to: 174-182
🤖 Prompt for AI Agents