Skip to content

If state is empty on run_finished event, don't trigger a state update #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
Merged

If state is empty on run_finished event, don't trigger a state update #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
342f0d4
If state is empty on run_finished event, don't trigger a state update
maxkorp Sep 4, 2025
c914287
update test
maxkorp Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions typescript-sdk/packages/client/src/agent/__tests__/legacy-bridged.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ describe("AbstractAgent.legacy_to_be_removed_runAgentBridged", () => {
const legacyEvents = await lastValueFrom(legacy$.pipe(toArray()));

// Verify events are in correct legacy format
expect(legacyEvents).toHaveLength(4); // Start, Content, End, AgentStateMessage
expect(legacyEvents).toHaveLength(3); // Start, Content, End

// TextMessageStart
expect(legacyEvents[0]).toMatchObject({
Expand All @@ -182,12 +182,12 @@ describe("AbstractAgent.legacy_to_be_removed_runAgentBridged", () => {
});

// Final AgentStateMessage
expect(legacyEvents[3]).toMatchObject({
type: "AgentStateMessage",
threadId: "test-thread-id",
agentName: "test-agent-id",
active: false,
});
// expect(legacyEvents[3]).toMatchObject({
// type: "AgentStateMessage",
// threadId: "test-thread-id",
// agentName: "test-agent-id",
// active: false,
// });
});

it("should pass configuration to the underlying run method", async () => {
Expand Down Expand Up @@ -304,7 +304,7 @@ describe("AbstractAgent.legacy_to_be_removed_runAgentBridged", () => {
const legacyEvents = await lastValueFrom(legacy$.pipe(toArray()));

// Verify events are in correct legacy format
expect(legacyEvents).toHaveLength(4); // Start, Content, End, AgentStateMessage
expect(legacyEvents).toHaveLength(3); // Start, Content, End

// TextMessageStart
expect(legacyEvents[0]).toMatchObject({
Expand All @@ -326,12 +326,12 @@ describe("AbstractAgent.legacy_to_be_removed_runAgentBridged", () => {
});

// Final AgentStateMessage
expect(legacyEvents[3]).toMatchObject({
type: "AgentStateMessage",
threadId: "test-thread-id",
agentName: "test-agent-id",
active: false,
});
// expect(legacyEvents[3]).toMatchObject({
// type: "AgentStateMessage",
// threadId: "test-thread-id",
// agentName: "test-agent-id",
// active: false,
// });
});

it("should transform tool call events with results into legacy events with correct tool name", async () => {
Expand All @@ -348,7 +348,7 @@ describe("AbstractAgent.legacy_to_be_removed_runAgentBridged", () => {
const legacyEvents = await lastValueFrom(legacy$.pipe(toArray()));

// Verify events are in correct legacy format
expect(legacyEvents).toHaveLength(5); // ActionExecutionStart, ActionExecutionArgs, ActionExecutionEnd, ActionExecutionResult, AgentStateMessage
expect(legacyEvents).toHaveLength(4); // ActionExecutionStart, ActionExecutionArgs, ActionExecutionEnd, ActionExecutionResult

// ActionExecutionStart
expect(legacyEvents[0]).toMatchObject({
Expand Down Expand Up @@ -379,11 +379,11 @@ describe("AbstractAgent.legacy_to_be_removed_runAgentBridged", () => {
});

// Final AgentStateMessage
expect(legacyEvents[4]).toMatchObject({
type: "AgentStateMessage",
threadId: "test-thread-id",
agentName: "test-agent-id",
active: false,
});
// expect(legacyEvents[4]).toMatchObject({
// type: "AgentStateMessage",
// threadId: "test-thread-id",
// agentName: "test-agent-id",
// active: false,
// });
});
});
5 changes: 5 additions & 0 deletions typescript-sdk/packages/client/src/legacy/convert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,11 @@ export const convertToLegacyEvents =
currentState.messages = syncedMessages;
}

// Only do an update if state is not empty
if (Object.keys(currentState).length === 0) {
return [];
}

return [
{
type: LegacyRuntimeEventTypes.enum.AgentStateMessage,
Expand Down
Loading