fix: support openai o1 model with custom model name. #552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
For my company, MediaTek, we use custom name called
aide-o1-preview
andaide-o1-mini
foro1
ando1-mini
viaAzure Service
.I know using
"o1-" in model_name
to detect o1 model can be bad, but as far as I know, only OpenAI o1 model containso1-
and it perfectly solve my problem.I am open to discuss more about how to fix it better.
Related issue number
#347
Checks