[Docs] Resolve mypy type-checking issues in docs generation files #621
+91
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix broken links
Review fixes
Fix upstream conflicts 2
Fix mypy type-checking issues in docs generation files
davorrunje
approved these changes
Jan 22, 2025
stellaxiang
pushed a commit
that referenced
this pull request
Jan 23, 2025
* WIP * updated mako template * WIP * Update meko template * Update meko template * Use pdoc3 for generating the API docs * Fix the generated docs/reference directory structure * Polishing * polishing * Remove setup.py * Remove docs-requirement file * Polishing * Polishing * Docs test * Docs test * Fix broken links * Remove docs extra from dev * Add missing packages * Remove redundant command * Add returns section to docs * Update docs * Update python version in workflow file * Pass OPENAI_API_KEY in CI * Fix review comments * Remove docs from dev extra * Add quotes around each packahe name * Polishing * WIP * WIP * Fix missed import in file * Fix missed third party imports in arxiv files * Add jinja in docs dependency * Cleanup * Polishing * wip * WIP * Fix mypy issues * fix typos * pre-commit fixed --------- Co-authored-by: Kumaran Rajendhiran <[email protected]> Co-authored-by: Davor Runje <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #622