Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Async Mocking in TelegramAgent Tests #693

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Fix Async Mocking in TelegramAgent Tests #693

wants to merge 26 commits into from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Fix Async Mocking in TelegramAgent Tests

This PR fixes async/await patterns in the TelegramAgent test suite by:

  1. Properly mocking async methods using AsyncMock
  2. Fixing return type issues for send_to_platform and wait_for_reply methods
  3. Ensuring consistent error propagation
  4. Maintaining test coverage for all platform-specific features

Changes

  • Updated async mocking strategy for TelegramAgent executor methods
  • Fixed type hints for async method returns
  • Improved error handling tests with proper async mocks
  • Maintained test coverage for message sending and reply monitoring

Testing

  • All tests pass with proper async/await patterns
  • Error scenarios properly tested with async mocks
  • Platform-specific features verified with correct async patterns

Link to Devin run: https://app.devin.ai/sessions/e8579140e3c247d0a18eea7a01855d99

marklysze and others added 25 commits January 16, 2025 04:00
@marklysze
Initial design, Discord agent
da53272 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Discord agent now sending messages, callable message send
e4b0421 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Optimised nested chat and cleaned up unnecessary code
bbd2f6e 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Separation of Discord async funcionality
7d11c16 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Handling of closed connection
78b5d60 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Discord agent, awaits replies
5f6f61b 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Initial slack agent implementation
98ad2b3 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Slack agent waiting capability
c4f30f8 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Slack agent working Async as well, yay!
c350368 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Merge remote-tracking branch 'origin/main' into commsagentsworkflow
3226b47
@marklysze
Telegram with library, sending message
1f49fbc 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Tidy, change to Telegram config
9dd9004 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Sync and Async Telegram!
d8067d5 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Comment tidy and remove unnecessary print.
223a8d3 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Tidy, naming, package extras, remove send_config
f449f39 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Extra versions specified
e83284c 
Signed-off-by: Mark Sze <[email protected]>
@marklysze
Merge remote-tracking branch 'origin/main' into commsagentsworkflow
1199dd5
@devin-ai-integration @marklysze
refactor(tests): remove async/await tests from telegram agent
cf1b5b6 
- Removed tests using async/await with synchronous send_to_platform
- Added documentation of removed tests and fix requirements
- Created pytest.ini for proper async test configuration
- Updated conftest.py with common test fixtures

This change removes tests that were incorrectly using async/await with
the synchronous send_to_platform method. A detailed list of removed tests
and their fix requirements has been documented in removed_tests.md.

Co-Authored-By: [email protected] <[email protected]>
@devin-ai-integration @marklysze
feat(comms): Add comprehensive test suite for platform agents
de616e2 
- Add tests for base CommsPlatformAgent class
- Add tests for platform-specific configs
- Add tests for platform error handling
- Add tests for platform executors
- Update Pydantic configuration for all platform agents
- Fix type hints and async/sync patterns

Co-Authored-By: [email protected] <[email protected]>
@devin-ai-integration @marklysze
test(comms): Update platform agent tests with mock sender and safer t…
7a1cb91 
…est values

- Add mock_sender fixture using ConversableAgent spec
- Update all test functions to use mock_sender instead of None
- Use safer mock values for platform configurations
- Maintain consistent mocking patterns across platform tests

Co-Authored-By: [email protected] <[email protected]>
@devin-ai-integration @marklysze
test(comms): Update handler tests with improved mocking and safer tes…
6c1acb6 
…t values

- Update mock values in test configurations
- Improve mocking patterns in handler tests
- Use consistent mocking approach across platform handlers
- Fix Field usage in MockConfig

Co-Authored-By: [email protected] <[email protected]>
@devin-ai-integration @marklysze
style(tests): Consistent formatting across platform test files
f902610 
Co-Authored-By: [email protected] <[email protected]>
@devin-ai-integration @marklysze
refactor(comms): Update Pydantic config to use ConfigDict and fix max…
4bf6e43 
…_replies handling

Co-Authored-By: [email protected] <[email protected]>
@devin-ai-integration @marklysze
fix(tests): Update TelegramAgent tests with proper async mocking
440b00e 
Co-Authored-By: [email protected] <[email protected]>
@devin-ai-integration @marklysze
test(comms): Update test configuration with consistent mock values
ec52fd3 
Co-Authored-By: [email protected] <[email protected]>
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ marklysze
❌ devin-ai-integration[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

Devin is currently unreachable - the session may have died.

1 similar comment
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

Devin is currently unreachable - the session may have died.

@qingyun-wu
Copy link
Collaborator

Please update the copyright header from

# Copyright (c) 2023 - 2025, Owners of https://github.com/ag2ai
#
# SPDX-License-Identifier: Apache-2.0

to

# Copyright (c) 2023 - 2025, AG2ai, Inc., AG2ai open-source projects maintainers and core contributors
#
# SPDX-License-Identifier: Apache-2.0

@davorrunje davorrunje self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davorrunje davorrunje

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CLAassistant @qingyun-wu @davorrunje @marklysze