[ add ] Relation.Binary.Morphism.Construct.On
#2872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
JacquesCarette
requested changes
Nov 18, 2025
MatthewDaggitt
approved these changes
Nov 20, 2025
Contributor
Author
|
@JacquesCarette hopefully we can merge now, if you're happy with the latest round of tweaks. As with my updated comment on #2871 I could imagine this getting refactored as part of a development of |
JacquesCarette
approved these changes
Nov 21, 2025
Contributor
JacquesCarette
left a comment
JacquesCarette
left a comment
There was a problem hiding this comment.
I still disagree about the name / placement of the module, but most definitely not willing to die on that hill! So I won't stand in the way of what is otherwise progress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2871 .