-
Notifications
You must be signed in to change notification settings - Fork 156
Define Dagger categories #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Define Dagger categories #1201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contents look good. I have some minor comments mostly about naming.
A question about conventions. Is there any logic to when you use Dagger (e.g. DaggerStr) vs Dag (e.g. DagCat) vs † vs D in names? If not, can we pick one (†?) to use in all names?
|
oops I was trying to see what was the requested change and accidentally clicked on re-request review. |
|
@ecavallo I've made the changes you requested (though GitHub is not showing it for some reason) can this be merged now? |
To do: