Skip to content

fix(examples): base64-encode HTML in site-to-markdown to prevent f-string injection #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ricardo-M-L wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(examples): base64-encode HTML in site-to-markdown to prevent f-string injection #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion examples/site-to-markdown/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,18 @@ async def site_to_markdown():
await page.screenshot(full_page=False, type='png')
).decode('utf-8')

# Base64-encode the HTML before injecting into the f-string so that
# triple-quote sequences, backslashes, or closing-string markers in
# the page content cannot break out of the generated Python source.
html_b64 = base64.b64encode(html.encode("utf-8")).decode("utf-8")

# Jupyter: Run code in sandbox to convert html to markdown
c.jupyter.execute_code(
code=f"""
import base64
from markdownify import markdownify
html = '''{html}'''

html = base64.b64decode("{html_b64}").decode("utf-8")
screenshot_b64 = "{screenshot_b64}"

md = f"{{markdownify(html)}}\\n\\n![Screenshot](data:image/png;base64,{{screenshot_b64}})"
Expand Down