chore(security): js-yaml + nanoid highs (lockfile-only) - #1355
Merged
Conversation
![revuto-review[bot]](https://avatars.githubusercontent.com/u/55848801?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is an auto review done by revuto.
The website lockfile updates are internally consistent, but the changelog overstates the scope and exposes an omitted security bump in the second npm lockfile.
| ## [Unreleased] | ||
|
|
||
| ### Security | ||
| - **Dependency lockfile bumps (website + VS Code extension)**: js-yaml |
There was a problem hiding this comment.
This is an auto review done by revuto.
This says the VS Code extension lockfile was bumped, but this PR changes only website/package-lock.json. editors/vscode/package-lock.json still pins node_modules/js-yaml to vulnerable 4.3.0 (lines 3201–3204), and the release workflow installs that lockfile with npm ci before packaging the extension. Please also update the VS Code lockfile to 4.3.1, or remove “+ VS Code extension” if this PR is intentionally website-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lockfile-only bumps: js-yaml GHSA-5p4m-2wfm-xmqj (quadratic !!omap) + nanoid GHSA-2v37-7h3g-55p8. Remaining audit noise is unpatched image-size (no upstream fix) — expected nonzero audit, out of scope.