fix(harness): interrupt orphan sub-agent when AgentSpawnTool parent subscription cancels (#2062)#2064
Merged
chickenlj merged 2 commits intoJul 9, 2026
Conversation
…ubscription cancels (agentscope-ai#2062)
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Hi maintainers — I'm the reporter of #2062 and submitted this fix shortly after filing the issue. I noticed #2063 by Quick comparison in case it helps the review:
Either PR works — if you prefer #2063 for any reason, please consider cherry-picking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix an orphan sub-agent leak in
AgentSpawnTool.execWithTimeoutPromotion: when the parent's subscription to theagentSpawnMono is cancelled (outerMono.timeout(), user stop, or upstream Reactor cancel), the inner executionMono — subscribed via fire-and-forget
.subscribe(...)— was never disposed, so the spawnedReActAgentkept runningindefinitely.
Closes #2062.
Root cause
execWithTimeoutPromotionbuilds the resultMono<String>by wrapping an innerMono<Msg>in aMonoSink+CompletableFuturebridge, then does plain.subscribe(...)on the inner Mono: