deps: update peerDeps to support React 19 without warnings #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- react 19 is also incompatible with `@testing-library/react` 13, so it needs updating as well, see next commits
agilgur5
added
kind: feature
This comment was marked as resolved.
This comment was marked as resolved.
|
Example seems to be working fine and not require any changes: |
|
I was wondering if fully updating to the new JSX transform might require a breaking change to not have the warning, but it seems like the end-user compiler can handle that automatically without the library needing to update? I didn't have any warnings like the upgrade guide mentions. The |
agilgur5
commented
Jan 3, 2025
agilgur5
added a commit
that referenced
this pull request
Jan 3, 2025
* deps: update peerDeps to support React 19 without warnings - react 19 is also incompatible with `@testing-library/react` 13, so it needs updating as well, see next commits * typings fixes required in new version * update @testing-library/react to compatible 16.1 version - react 19 support in https://github.com/testing-library/react-testing-library/releases/tag/v16.1.0 (cherry picked from commit ebec40b) - fixed various merge conflicts: - no typings changes as there is no TS on the `v1.0.x` branch - no `@types/` updates either - isolate surrounding deps changes etc (only update `react`, `react-dom`, and `@testing-library/react`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
peerDependenciesrange to support React 19. Update devDeps, typings, tests to support / use React 19Details
seems to work without any source component modifications needed on React 19
ensure tests pass with React 19
react-dom19,@types/react19Future Work
Backport this to v1.0.7, i.e. prior to the TypeScript rewrite (TypeScript Rewrite #42) being merged