Internal Stability & Automation Improvements #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- needed to be auto-updated - seems to have mostly added carets to deps
- still need to update the 3 year old build system here, but will probably update to TS tooling
- have been using it in my editor and made some commits to follow the style, but not "officially" in the repo (deps): add standard and babel-eslint as its parser
- v13 requires const instead of let usage - v13 requires line in b/t class members - v12 requires spacing in curly braces - the last two I'm not a huge fan of, but they make sense matching behavior elsewhere more or else. also it's standard so that's just what it is, no bikeshedding - the **very old** webpack.production.config.js also had a lint error from v6+ on using __dirname without path.join
- don't have tests yet, so for now just test lint, transpile/bundle, and pack - alter the test command to use the production build
- for dat slick build | passing look
- these are somewhat defined by how I usually sort them - can add typings and test coverage in the status section when those are eventually added
- makes my job easier and makes it possible for others to replicate the same style changelog easily
- because whitelist are better practices and safer than blacklists
agilgur5
force-pushed
the
stability-improvements
branch
from
f27e318 to
589a0e4
Compare
agilgur5
commented
Jul 14, 2019
agilgur5
added
the
kind: internal
Repository owner
locked as resolved and limited conversation to collaborators
Feb 11, 2022
agilgur5
added
the
scope: tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update devDeps and outdated package-lock, audit devDeps, officially add Standard linting, add Travis CI, auto-generate changelog, etc
Basically a bunch of automation other than/prior to adding tests and changing the (3 year old) build process.
Would like to add some community improvements & automation later as well, such as Issue and PR templates, a
CONTRIBUTING.md(with a "vision" and docs on automation and conventions), possiblygit-cz, and aCONTRIBUTORS.mdorall-contributors