Skip to content

fix: propagate OutputCheckError to caller instead of silently returning #7478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yanhu007 wants to merge 1 commit into from
Closed

fix: propagate OutputCheckError to caller instead of silently returning #7478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions libs/agno/agno/agent/_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,8 @@ def _run(

return run_response
except (InputCheckError, OutputCheckError) as e:
# Handle exceptions during streaming
# Handle validation exceptions — propagate to caller so
# try/except OutputCheckError works as documented.
run_response.status = RunStatus.error
# If the content is None, set it to the error message
if run_response.content is None:
Expand All @@ -656,7 +657,7 @@ def _run(
user_id=user_id,
)

return run_response
raise
except KeyboardInterrupt:
run_response = cast(RunOutput, run_response)
run_response.status = RunStatus.cancelled
Expand Down Expand Up @@ -1734,7 +1735,8 @@ async def _arun(

return run_response
except (InputCheckError, OutputCheckError) as e:
# Handle exceptions during streaming
# Handle validation exceptions — propagate to caller so
# try/except OutputCheckError works as documented.
run_response.status = RunStatus.error
# If the content is None, set it to the error message
if run_response.content is None:
Expand All @@ -1751,7 +1753,7 @@ async def _arun(
user_id=user_id,
)

return run_response
raise

except KeyboardInterrupt:
run_response = cast(RunOutput, run_response)
Expand Down Expand Up @@ -3049,7 +3051,8 @@ def _continue_run(
return run_response
except (InputCheckError, OutputCheckError) as e:
run_response = cast(RunOutput, run_response)
# Handle exceptions during streaming
# Handle validation exceptions — propagate to caller so
# try/except OutputCheckError works as documented.
run_response.status = RunStatus.error
# If the content is None, set it to the error message
if run_response.content is None:
Expand All @@ -3061,7 +3064,7 @@ def _continue_run(
agent, run_response=run_response, session=session, run_context=run_context, user_id=user_id
)

return run_response
raise
except KeyboardInterrupt:
run_response = cast(RunOutput, run_response)
run_response.status = RunStatus.cancelled
Expand Down Expand Up @@ -3842,7 +3845,8 @@ async def _acontinue_run(
return run_response
except (InputCheckError, OutputCheckError) as e:
run_response = cast(RunOutput, run_response)
# Handle exceptions during streaming
# Handle validation exceptions — propagate to caller so
# try/except OutputCheckError works as documented.
run_response.status = RunStatus.error
# If the content is None, set it to the error message
if run_response.content is None:
Expand All @@ -3859,7 +3863,7 @@ async def _acontinue_run(
user_id=user_id,
)

return run_response
raise

except KeyboardInterrupt:
run_response = cast(RunOutput, run_response)
Expand Down
Loading