further mcp integration #398 #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR further integrates the MCP Server by adding a new tool to list validation parameters, extending the validation call pipeline to accept custom parameters, enhancing request building and resource serialization, updating documentation and endpoints, bumping project versions, and adding completion logging. Sequence diagram for validation with custom parameters in MCP integrationsequenceDiagram
participant Client
participant MCPMatchboxBridge
participant RequestBuilder
participant RestfulServer
participant MockHttpServletResponse
Client->>MCPMatchboxBridge: Call getValidationResult with contextMap
MCPMatchboxBridge->>MCPMatchboxBridge: Parse validationparams from contextMap
MCPMatchboxBridge->>RequestBuilder: Build request with custom query params
RequestBuilder->>RestfulServer: handleRequest()
RestfulServer->>MockHttpServletResponse: Write response
MCPMatchboxBridge->>Client: Return validation result
Class diagram for new and updated MCP integration classesclassDiagram
class McpMatchboxBridge {
+generateTools()
+getExtraValidationParameters(contextMap, interaction)
+getValidationResult(contextMap, interaction)
}
class ToolFactory {
+listValidationParameters()
+listFhirProfilesToValidateFor()
}
class RequestBuilder {
+buildRequest()
}
class CrossVersionResourceUtils {
+serializeR5(Resource, MatchboxFhirFormat, Writer)
+serializeR5(IBase, MatchboxFhirFormat, Writer)
}
McpMatchboxBridge --> ToolFactory : uses
McpMatchboxBridge --> RequestBuilder : uses
McpMatchboxBridge --> CrossVersionResourceUtils : uses
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider refactoring the duplicated FHIR request/response handling in getExtraValidationParameters and existing call handlers into a shared helper to reduce boilerplate.
- The manual JSON array construction in getExtraValidationParameters appends a trailing comma before the closing bracket, leading to invalid JSON—either trim the last comma or use a JSON builder.
- Parsing validationparams as a comma-separated string is brittle—consider accepting and validating a structured JSON object for more reliable parameter handling.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider refactoring the duplicated FHIR request/response handling in getExtraValidationParameters and existing call handlers into a shared helper to reduce boilerplate.
- The manual JSON array construction in getExtraValidationParameters appends a trailing comma before the closing bracket, leading to invalid JSON—either trim the last comma or use a JSON builder.
- Parsing validationparams as a comma-separated string is brittle—consider accepting and validating a structured JSON object for more reliable parameter handling.
## Individual Comments
### Comment 1
<location> `docs/validation-with-ai-tutorial.md:90` </location>
<code_context>
```
-The MCP-Server can be reached at the endpoint `http://<<your-url>>/matchbox/mcp/sse`
+The MCP-Server can be reached at the endpoint `http://<<your-url>>/matchbox(v3)/mcp/message`
### Setting up matchbox for Claude Desktop
</code_context>
<issue_to_address>
**suggestion:** Inconsistent use of parentheses in endpoint URL.
Ensure the endpoint format is consistent across all documentation references.
Suggested implementation:
```
The MCP-Server can be reached at the endpoint `http://<<your-url>>/matchbox/v3/mcp/message`
```
Review the rest of the documentation for any other references to the endpoint and update them to use `/matchbox/v3/mcp/message` (without parentheses) for consistency.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| ``` | ||
| The MCP-Server can be reached at the endpoint `http://<<your-url>>/matchbox/mcp/sse` | ||
| The MCP-Server can be reached at the endpoint `http://<<your-url>>/matchbox(v3)/mcp/message` |
There was a problem hiding this comment.
suggestion: Inconsistent use of parentheses in endpoint URL.
Ensure the endpoint format is consistent across all documentation references.
Suggested implementation:
The MCP-Server can be reached at the endpoint `http://<<your-url>>/matchbox/v3/mcp/message`
Review the rest of the documentation for any other references to the endpoint and update them to use /matchbox/v3/mcp/message (without parentheses) for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Enhance MCP Server integration by adding support for listing and passing extra validation parameters, updating request handling and serialization utilities, logging validation completion, and refreshing documentation and versioning to 4.0.14.
New Features:
Enhancements:
Build:
Documentation: