Skip to content

Conversation

Copy link

Copilot AI commented Dec 29, 2025

Commit 8b4d0cb changed the CodeSystem import from R4 to R5 when adding CodeableConcept validation support. This created an inconsistency with the established multi-version provider pattern.

Changes

  • Reverted CodeSystemProvider.java import from org.hl7.fhir.r5.model.CodeSystem to org.hl7.fhir.r4.model.CodeSystem

Pattern

The terminology providers follow this structure:

  • R4 models for method signatures and return types (e.g., searchCodeSystem())
  • R5 models used internally within operations for version conversion
  • getResourceType() switches on fhirVersion to return version-specific classes

This matches the existing ValueSetProvider.java implementation:

import org.hl7.fhir.r4.model.ValueSet;  // R4 for return type
import org.hl7.fhir.r5.model.Coding;    // R5 for internal ops

@Search
public List<ValueSet> searchValueSets() {
    return Collections.emptyList();
}

@Override
public Class<? extends IBaseResource> getResourceType() {
    return switch (this.fhirVersion) {
        case R4 -> org.hl7.fhir.r4.model.ValueSet.class;
        case R4B -> org.hl7.fhir.r4b.model.ValueSet.class;
        case R5 -> org.hl7.fhir.r5.model.ValueSet.class;
        // ...
    };
}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Author

Copilot AI commented Dec 29, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • jitpack.io
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.11 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/matchbox/matchbox org.codehaus.plexus.classworlds.launcher.Launcher clean compile -pl matchbox-server -am -DskipTests (dns block)
  • packages.fhir.org
    • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java -jar /home/REDACTED/work/matchbox/matchbox/matchbox-server/target/surefire/surefirebooter-20251229173241584_89.jar /home/REDACTED/work/matchbox/matchbox/matchbox-server/target/surefire 2025-12-29T17-31-28_982-jvmRun1 surefire-20251229173241584_87tmp surefire_1-20251229173241584_88tmp 4/bin/env 0 -j ACCEPT env (dns block)
  • packages2.fhir.org
    • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java -jar /home/REDACTED/work/matchbox/matchbox/matchbox-server/target/surefire/surefirebooter-20251229173241584_89.jar /home/REDACTED/work/matchbox/matchbox/matchbox-server/target/surefire 2025-12-29T17-31-28_982-jvmRun1 surefire-20251229173241584_87tmp surefire_1-20251229173241584_88tmp 4/bin/env 0 -j ACCEPT env (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback from PR #449 for release 4.0.16 Revert CodeSystem import to R4 for consistency with provider pattern Dec 29, 2025
Copilot AI requested a review from oliveregger December 29, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants