-
Notifications
You must be signed in to change notification settings - Fork 25
2026/01/07 Release 4.0.16 #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideStabilizes locale handling in the FHIR R5 BaseWorkerContext by persisting and only propagating locale changes when the value actually changes, and updates the 4.0.16 release changelog metadata for date and issue references. Sequence diagram for locale update propagation in BaseWorkerContext.setLocalesequenceDiagram
actor Client
participant BaseWorkerContext
participant SuperWorkerContext
participant Logger
Client->>BaseWorkerContext: setLocale(locale)
alt this.locale is null
BaseWorkerContext->>BaseWorkerContext: this.locale = locale
BaseWorkerContext->>SuperWorkerContext: setLocale(locale)
else this.locale not null and different from locale
BaseWorkerContext->>BaseWorkerContext: this.locale = locale
BaseWorkerContext->>SuperWorkerContext: setLocale(locale)
alt locale not null
BaseWorkerContext->>Logger: info(changing locale to languageTag)
else locale is null
BaseWorkerContext->>Logger: info(resettting locale)
end
else this.locale equals locale
Note over BaseWorkerContext: No call to SuperWorkerContext.setLocale
end
Class diagram for updated BaseWorkerContext locale handlingclassDiagram
class BaseWorkerContext {
- ContextUtilities cutils
- List~String~ suppressedMappings
- Locale locale
+ BaseWorkerContext()
+ void copy(BaseWorkerContext other)
+ void setLocale(Locale locale)
}
class SuperWorkerContext {
+ void setLocale(Locale locale)
}
BaseWorkerContext --|> SuperWorkerContext
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- In
setLocale, consider simplifying the change-detection logic by using an early return withObjects.equals(this.locale, locale)and only updating/logging when the value actually changes, which will make the method more readable and less nested. - The info log message "changing locale to" concatenates without a separating space; update the string (e.g., "changing locale to ") to avoid slightly awkward log output.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `setLocale`, consider simplifying the change-detection logic by using an early return with `Objects.equals(this.locale, locale)` and only updating/logging when the value actually changes, which will make the method more readable and less nested.
- The info log message "changing locale to" concatenates without a separating space; update the string (e.g., "changing locale to ") to avoid slightly awkward log output.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Hi Oliver, I am with Canada Health Infoway and we are very interested in this release as it updates the HL7 Validator to v6.7.10. Thanks for getting this done! Azhar |
it should go out tomorrow, final testing stage ... |
Summary by Sourcery
Stabilize locale handling in the base worker context and update release documentation for version 4.0.16.
Enhancements:
Documentation: