Skip to content

Conversation

nv-tusharma
Copy link
Contributor

@nv-tusharma nv-tusharma commented Aug 18, 2025

Closes OPS-702 as well

Overview:

vLLM currently builds NIXL, Dynamo, and other dependencies from source which attributes to the high build time. This PR enables the vLLM Dockerfile to use the dynamo base container build so that the vLLM build can use the build time improvement made in Dockerfile in the vLLM build to reduce container build times.

Details:

  • Restructure Dockerfile.vllm to use Dynamo Base as base container for build
  • Update build.sh to use a two-step approach for building framework containers - build dynamo first and then build Dockerfile.vLLM

Where should the reviewer start?

  • container/Dockerfile
  • container/Dockerfile.vllm
  • container/build.sh

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@nv-tusharma nv-tusharma changed the title [build]: OPS597: Restructure vLLM dockerfile to use dynamo base container instead of building from source build: OPS597: Restructure vLLM dockerfile to use dynamo base container instead of building from source Aug 18, 2025
@github-actions github-actions bot added the build label Aug 18, 2025
@nv-tusharma
Copy link
Contributor Author

/ok to test 06006d3

@nv-tusharma nv-tusharma changed the title build: OPS597: Restructure vLLM dockerfile to use dynamo base container instead of building from source build: OPS-597: Restructure vLLM dockerfile to use dynamo base container instead of building from source Aug 19, 2025
@nv-anants nv-anants changed the base branch from main to ci/vllm-github August 19, 2025 17:50
Copy link

copy-pr-bot bot commented Aug 19, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dillon-cullinan dillon-cullinan force-pushed the tusharma/vllm-dynamo-base-integ branch from 00b26a5 to 9ae81be Compare August 19, 2025 19:09
@nv-tusharma nv-tusharma marked this pull request as ready for review August 19, 2025 19:54
@nv-tusharma nv-tusharma requested a review from nnshah1 as a code owner August 19, 2025 19:54
@nv-anants nv-anants merged commit 5b43a76 into ci/vllm-github Aug 25, 2025
8 of 11 checks passed
@nv-anants nv-anants deleted the tusharma/vllm-dynamo-base-integ branch August 25, 2025 20:53
nv-anants added a commit that referenced this pull request Aug 28, 2025
…ner and enable s3 sccache to speed up builds (#2503)

Signed-off-by: Anant Sharma <[email protected]>
Co-authored-by: Anant Sharma <[email protected]>
Co-authored-by: Dillon Cullinan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants