-
Notifications
You must be signed in to change notification settings - Fork 642
chore: add e2e test for reasoning_effort for gpt-oss model #3421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: zhongdaor <[email protected]>
WalkthroughAdds an end-to-end reasoning_effort frontend test. Introduces GPTOSSWorkerProcess to run a GPT-OSS worker with health checks. Starts DynamoFrontendProcess and the worker, issues two chat completions with low/high reasoning_effort, compares reasoning metrics, and enhances test constants by adding the GPT_OSS model to TEST_MODELS. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Test as PyTest
participant Frontend as DynamoFrontendProcess
participant Worker as GPTOSSWorkerProcess (GPT-OSS)
participant API as HTTP Endpoint
Test->>Frontend: start()
Test->>Worker: start() + health checks
Note over Worker,Frontend: Both processes running
Test->>API: POST /chat/completions (reasoning_effort="low")
API->>Worker: Forward request
Worker-->>API: Response (low-effort reasoning)
API-->>Test: JSON response
Test->>API: POST /chat/completions (reasoning_effort="high")
API->>Worker: Forward request
Worker-->>API: Response (high-effort reasoning)
API-->>Test: JSON response
Test->>Test: Extract metrics and compare<br/>(high >= low)
Test->>Frontend: stop()
Test->>Worker: stop()
rect rgba(230,245,255,0.6)
Note right of Test: Validates non-200 errors, missing fields,<br/>and invalid JSON in health checks.
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Pre-merge checks❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
tests/frontend/reasoning_effort/test_reasoning_effort.py
(1 hunks)tests/utils/constants.py
(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
tests/frontend/reasoning_effort/test_reasoning_effort.py (3)
tests/utils/managed_process.py (1)
ManagedProcess
(71-568)tests/utils/payloads.py (1)
check_models_api
(191-202)tests/conftest.py (2)
runtime_services
(218-221)predownload_models
(109-121)
🪛 GitHub Actions: Pre Merge Validation of (ai-dynamo/dynamo/refs/pull/3421/merge) by zhongdaor-nv.
tests/frontend/reasoning_effort/test_reasoning_effort.py
[error] 1-1: isort formatting changed imports in test_reasoning_effort.py.
[error] 1-1: black formatting changed/reformatted test_reasoning_effort.py.
🪛 Ruff (0.13.3)
tests/frontend/reasoning_effort/test_reasoning_effort.py
129-129: Avoid specifying long messages outside the exception class
(TRY003)
139-139: Avoid specifying long messages outside the exception class
(TRY003)
151-151: Avoid specifying long messages outside the exception class
(TRY003)
160-160: Unused function argument: runtime_services
(ARG001)
160-160: Unused function argument: predownload_models
(ARG001)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: trtllm (arm64)
- GitHub Check: trtllm (amd64)
- GitHub Check: sglang
- GitHub Check: vllm (arm64)
- GitHub Check: vllm (amd64)
- GitHub Check: Build and Test - dynamo
Signed-off-by: zhongdaor <[email protected]>
Signed-off-by: zhongdaor <[email protected]>
Signed-off-by: zhongdaor <[email protected]>
Signed-off-by: zhongdaor-nv <[email protected]>
Signed-off-by: zhongdaor <[email protected]> Signed-off-by: zhongdaor-nv <[email protected]> Signed-off-by: Piotr Tarasiewicz <[email protected]>
Overview:
Add e2e tests for gpt oss reasoning effort
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit