Skip to content

fix: bettter logging, decrease randomness #3424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: bettter logging, decrease randomness #3424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/utils/payload_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@


def chat_payload_default(
repeat_count: int = 3,
repeat_count: int = 2,
expected_response: Optional[List[str]] = None,
expected_log: Optional[List[str]] = None,
max_tokens: int = 150,
temperature: float = 0.1,
max_tokens: int = 300,
temperature: float = 0,
stream: bool = False,
) -> ChatPayload:
return ChatPayload(
Expand All @@ -37,11 +37,11 @@ def chat_payload_default(


def completion_payload_default(
repeat_count: int = 3,
repeat_count: int = 2,
expected_response: Optional[List[str]] = None,
expected_log: Optional[List[str]] = None,
max_tokens: int = 150,
temperature: float = 0.1,
max_tokens: int = 300,
temperature: float = 0,
stream: bool = False,
) -> CompletionPayload:
return CompletionPayload(
Expand Down
4 changes: 3 additions & 1 deletion tests/utils/payloads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,10 @@ def validate(self, response: Any, content: str) -> None:
if not content or expected not in content:
missing_expected.append(expected)
if missing_expected:
preview = (content or "")[:1000]
raise AssertionError(
f"Expected content not found in response. Missing: {missing_expected}"
f"Expected content not found in response. Missing: {missing_expected}. "
f"Content preview (first 1000 chars): {preview!r}"
)
logger.info(f"SUCCESS: All expected_responses: {self.expected_response} found.")

Expand Down
Loading