etcd-less #3442
Draft
etcd-less #3442
+836
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnshah1
reviewed
Oct 6, 2025
| /// Status of a service instance | ||
| #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)] | ||
| pub enum InstanceStatus { | ||
| /// Instance is ready to receive traffic |
There was a problem hiding this comment.
question do we need ready / not ready - or just rely on added and removed?
Signed-off-by: Anna Tchernych <[email protected]>
nnshah1
reviewed
Oct 14, 2025
| let metadata = self.metadata.clone(); | ||
| let readiness_status = self.readiness_status.clone(); | ||
|
|
||
| let app = axum::Router::new() |
There was a problem hiding this comment.
can we combine this with the system http server?
nnshah1
reviewed
Oct 14, 2025
| impl KubernetesServiceDiscovery { | ||
| /// Create a new Kubernetes service discovery client | ||
| pub async fn new(namespace: String) -> Result<Self> { | ||
| // TODO: Initialize Kubernetes client when kube crate is available |
There was a problem hiding this comment.
question: what is blocking kube crate?
nnshah1
reviewed
Oct 14, 2025
| } | ||
|
|
||
| #[async_trait] | ||
| impl ServiceRegistry for EtcdServiceDiscovery { |
There was a problem hiding this comment.
question: currently we have 'endpoint' discovery - do we maintain that here or is there some common portion of the metadata that will include endpoints?
nnshah1
reviewed
Oct 14, 2025
|
|
||
| /// Represents a discovered service instance | ||
| #[derive(Debug, Clone)] | ||
| pub struct Instance { |
There was a problem hiding this comment.
for endpoints - how would they be discovered or listed?
how do we get the client from the instance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
closes https://linear.app/nvidia/issue/DEP-386/kubernetes-implementation-for-servicediscovery-interface