Skip to content

Conversation

mkhazraee
Copy link
Contributor

What?

Describe what this PR is doing.

Why?

Justification for the PR. If there is an existing issue/bug, please reference it. For
bug fixes, the 'Why?' and 'What?' can be merged into a single item.

How?

It is optional, but for complex PRs, please provide information about the design,
architecture, approach, etc.

Copy link

👋 Hi mkhazraee! Thank you for contributing to ai-dynamo/nixl.

Your PR reviewers will review your contribution then trigger the CI to test your changes.

🚀

@mkhazraee
Copy link
Contributor Author

/build

@mkhazraee
Copy link
Contributor Author

/build

@brminich
Copy link
Contributor

If you plan to merge this PR eventually, pls consider adding new tests for libfabric rather than replacing existing UCX ones

@mkhazraee
Copy link
Contributor Author

If you plan to merge this PR eventually, pls consider adding new tests for libfabric rather than replacing existing UCX ones

@brminich I plan to merge #822 based on the talks I had with yossi, making the tests more general. This one is still there for the CI test and nixlbench to see if we can get it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants