OBJ: add ca_bundle option in obj plugin and nixlbench #806
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zirui Liu <[email protected]>
Signed-off-by: Zirui Liu <[email protected]>
ziruiliu
requested review from
aranadive,
ovidiusm,
brminich,
w1ldptr,
barneuman,
etoledano and
vvenkates27
as code owners
|
👋 Hi ziruiliu! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
ovidiusm
reviewed
Sep 18, 2025
|
/build |
update with clearer description Co-authored-by: ovidiusm <[email protected]> Signed-off-by: ziruiliu <[email protected]>
ovidiusm
previously approved these changes
Sep 18, 2025
|
It also needs to be added to benchmark/kvbench/commands/args.py (see obj_endpoint_override for example) |
Signed-off-by: Zirui Liu <[email protected]>
Hi @ovidiusm , I have updated benchmark/kvbench/commands/args.py according to you suggestion |
aranadive
approved these changes
Sep 19, 2025
|
/ok to test b85ef3e |
|
/build |
|
/ok to test 5c2f091 |
|
/build |
ovidiusm
approved these changes
Sep 24, 2025
|
Hi @w1ldptr and @barneuman, would you please review this change that add ca_bundle in obj plugin? |
evgeny-leksikov
pushed a commit
to evgeny-leksikov/nixl
that referenced
this pull request
Sep 29, 2025
* obj: Add ca_bundle option for S3 compatible storage Signed-off-by: Zirui Liu <[email protected]> * obj: Add ca_bundle option in README.md Signed-off-by: Zirui Liu <[email protected]> * Update benchmark/nixlbench/src/utils/utils.cpp update with clearer description Co-authored-by: ovidiusm <[email protected]> Signed-off-by: ziruiliu <[email protected]> * obj: add ca_bundle option Signed-off-by: Zirui Liu <[email protected]> --------- Signed-off-by: Zirui Liu <[email protected]> Signed-off-by: ziruiliu <[email protected]> Co-authored-by: ovidiusm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a new param 'ca_bundle' for obj plugin and corresponding option 'obj_ca_bundle' in nixlbench
Why?
AWS cpp sdk does not honor environment variable AWS_CA_BUNDLE when initializing ClientConfiguration.
When testing with S3-compatible storage with self-signed certificates, the plugin and nixlbench are not working
How?
pass certificate path to the plugin, and set caFile when initializing ClientConfiguration