-
Notifications
You must be signed in to change notification settings - Fork 38
Add fine coordinates to the model for easier inference handling #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
frodre
wants to merge
29
commits into
main
Choose a base branch
from
feature/downscaling-model-fine-coords
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 27 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
754f28a
Initial shot
frodre 7c5b4c5
Make fine coords required
frodre c7f58d9
Fine coords required for paired data
frodre 563b57a
Mesh with previous updates in refactor pr
frodre f4218dd
Simplify event downscaler coordinate in run()
frodre 68cab61
use batch latlon coardinates for coarse
frodre 83ca043
Make fine coord loader public
frodre 794a7d4
BatchLatLon coord access consistency
frodre b542080
linting
frodre 5add727
Add no coords checkpoint with path test
frodre 36e80db
Small tweaks
frodre b19c9d6
Add load_fine_coords_from_path test
frodre 7acf87c
Update fme/downscaling/models.py
frodre eba2749
Update fme/downscaling/models.py
frodre 2c25f1d
Update fme/downscaling/models.py
frodre 81e4eb8
use latlon coords .to method for device fix
frodre 325d324
Redo based on Anna's comments
frodre 1fac745
Remove from_state docstring
frodre 3ef1613
Move all state loading cases into static inputs code
frodre 36e8101
Remove unused function from fme.downscaling.data
frodre 3f95457
fine_coords -> full_fine_coords
frodre 6c9fcf7
Remove duplicated tests from models.py
frodre 4b58b86
Minor fixes
frodre 7e36f55
Fix imports
frodre a85fb05
Final cleanup
frodre b1ee3d4
Merge branch 'main' into feature/downscaling-model-fine-coords
frodre bedd276
Add coordinate validation and use training data as a fallback vs. sta…
frodre a9dbae3
Updates based on discussion w/ Anna
frodre 46670ff
Merge branch 'main' into feature/downscaling-model-fine-coords
frodre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make my VSCode linter happy