Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sections 1 #30

Merged
merged 24 commits into from
Sep 22, 2019
Merged

Add sections 1 #30

merged 24 commits into from
Sep 22, 2019

Conversation

Aichnerc
Copy link
Member

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Aichnerc added 21 commits August 19, 2019 01:17
@Aichnerc
Add CallToAction section
1cf5587 
The section Call To Action has been added.
@Aichnerc
Improve Footer
72a2cbd 
More padding has been added to the Footer component.
@Aichnerc
Improve call to action
4638eba 
Images and Parallax have been implemented.
@Aichnerc
Add particles
52b7f7e 
Particle effects have been added.
@Aichnerc
Remove particle js
3de81e8 
The particle js library has been removed.
@Aichnerc
Improve text
6c002bc 
A text within the CallToAction component has been improved.
@Aichnerc
Add Section
da6d5ac 
The Services section has been added.
@Aichnerc
Add cleanup
3a86a1c 
All components have been cleaned up
abit.
@Aichnerc
Add Weddings section
f891bfd 
The weddings section has been added. A fancy
button has been added as well.
@Aichnerc
Fix Weddings section
d2af95e 
The wedding section component has been
placed in the wrong folder.
@Aichnerc
Rename Weddings and add content
c34990f 
The Weddings component is now called Additional
and will hold additional services we offer. Including
Social Media, Tutorials, Weddings, ...
A new button type has been added.
@Aichnerc
Improve Additional section
8cd2f6f 
More data and a row/col system has been
added to the Additional section.
@Aichnerc
Remove old logo
13c62c4 
The old png logo has been replaced by SVG images.
@Aichnerc
Add modules
07b22ad 
React-loadable and React-loadable-visibility modules
have been added.
@Aichnerc
Improve logo coloring
8739e99 
An id has been added to the logos to distinctly
manage its color apart from other SVG files.
@Aichnerc
Add new hero image
55c77de 
An image has been added to the Hero component.
@Aichnerc
Improve hero content
c3df6b0 
The content of the hero component has been improved.
@Aichnerc
Improve performance
5e4e1a5 
The react-loadable modules have been implemented.
Static components were assigned the PureComponent
type of components.
@Aichnerc
Improve code qualtiy
46b85ce 
The code quality of the Additional component section
has been improved.
@Aichnerc
Improve code quality
0f0e611 
The code quality of the CallToAction component section
has been improved.
@Aichnerc
Fix logo color
6df438c 
The navbar logo color has been fixed in light mode.
@Aichnerc Aichnerc added enhancement Enhancement of an existing feature or request feature Completely new feature or request labels Sep 16, 2019
@Aichnerc Aichnerc added this to the 1.0.0 milestone Sep 16, 2019
@Aichnerc Aichnerc requested a review from kleberbaum September 16, 2019 13:53
@Aichnerc Aichnerc self-assigned this Sep 16, 2019
Aichnerc
Aichnerc commented Sep 16, 2019
View reviewed changes
Copy link
Member Author

@Aichnerc Aichnerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a line-length change it should be okay.

@Aichnerc
Improve code quality
6b9c345 
Enforcement of the max. chars per line policy.
@Aichnerc
Improve code quality
645b172 
Ref: A function with a name starting with an
uppercase letter should only be used as a
constructor.
kleberbaum
kleberbaum suggested changes Sep 16, 2019
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge after a few changes.

@Aichnerc
Remove particle.js
f29f14a 
Particle.js has been removed from the packages
used in this project.
@Aichnerc Aichnerc requested a review from kleberbaum September 22, 2019 17:17
kleberbaum
kleberbaum approved these changes Sep 22, 2019
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge.

@kleberbaum kleberbaum merged commit d7d6808 into master Sep 22, 2019
This was referenced Oct 20, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleberbaum kleberbaum kleberbaum approved these changes

Assignees

@Aichnerc Aichnerc

Labels
enhancement Enhancement of an existing feature or request feature Completely new feature or request
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Aichnerc @kleberbaum