forked from expressjs/compression
-
Notifications
You must be signed in to change notification settings - Fork 20
Adding callback to res.write and res.end for streaming support #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've made the same PR to the original |
…r they are coded.
scttdavs
pushed a commit
to scttdavs/shrink-ray
that referenced
this pull request
Nov 2, 2018
Add Greenkeeper badge 🌴
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to use
compression
to enable GZIP on streamed responses that flush multiple chunks to the browser whenever the implementer wants. (This is especially useful when implementing a BigPipe algorithm such as with myexpress-stream
library.) As a result, I need a sure way of flushing only after a chunk of output has been zipped.Currently, the following code encounters a race condition because
res.write
is not blocking. As a result, it's possible thatres.flush
will execute beforeres.write
completes.I've confirmed the above by ensuring this works as expected:
What I'd prefer to do, and what this PR enables, is the following: