Skip to content

🎨 Palette: Add aria-label to icon-only close buttons in modals#28

Open
aicoder2009 wants to merge 2 commits intomainfrom
palette/fix-aria-label-modals-2193066867364618428
Open

🎨 Palette: Add aria-label to icon-only close buttons in modals#28
aicoder2009 wants to merge 2 commits intomainfrom
palette/fix-aria-label-modals-2193066867364618428

Conversation

@aicoder2009
Copy link
Copy Markdown
Owner

🎨 Palette: Added aria-label to icon-only modal close buttons

💡 What: Added aria-label="Close" to the modal close buttons in src/app/page.tsx.
🎯 Why: The close buttons only used the × HTML entity, which lacks context for screen readers. Adding an aria-label ensures these buttons are properly announced.
Accessibility: Improved screen reader support for closing modals (Privacy Policy, Terms of Service, Report Issue).


PR created automatically by Jules for task 2193066867364618428 started by @aicoder2009

Added `aria-label="Close"` to the icon-only buttons using `×` in `src/app/page.tsx` that are used to close modals (Privacy Policy, Terms of Service, Report Issue). This improves accessibility for screen readers.

Co-authored-by: aicoder2009 <[email protected]>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings April 27, 2026 10:19
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
opencitation Ready Ready Preview, Comment May 1, 2026 6:24pm

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves accessibility of the landing page’s modal close controls by providing an accessible name for icon-only “×” close buttons, ensuring screen readers announce the intent correctly.

Changes:

  • Added aria-label="Close" to the close buttons for the Privacy Policy, Terms of Service, and Report Issue modals on the landing page.
  • Added a Palette learning note documenting the accessibility issue and the mitigation pattern.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/app/page.tsx Adds aria-label="Close" to icon-only modal close buttons to improve screen reader support.
.jules/palette.md Documents the accessibility learning/action for future similar UI changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aicoder2009 aicoder2009 closed this May 1, 2026
@aicoder2009 aicoder2009 reopened this May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants