Add missing build-backend to pyproject.toml#252
Conversation
Add the missing `build-backend` entry to `pyproject.toml`, to fix building with tools that strictly implement PEP 517. PEP 517 requires the entry to be present, providing a fallback to the deprecated legacy setuptools backend _if_ `setup.py` is present, which is not the case here. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #252 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 5 5
Lines 1399 1399
Branches 73 73
=======================================
Hits 1377 1377
Misses 16 16
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s packaging configuration to make PEP 517 builds work reliably by explicitly defining the setuptools build backend in pyproject.toml, avoiding reliance on legacy fallback behavior.
Changes:
- Add
build-backend = "setuptools.build_meta"under[build-system]inpyproject.toml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -36,6 +36,7 @@ version = {attr = "aiodns.__version__"} | |||
| [build-system] | |||
| # pycares required because of the fact that it's in the __init__ module | |||
| requires = ["setuptools", "pycares"] | |||
There was a problem hiding this comment.
This is complete and utter bullshit. wheel was never required, as setuptools always added it automatically via get_requires_for_build_wheel. It only was listed in documentation as a mistake, that was fixed long ago.
What do these changes do?
Add the missing
build-backendentry topyproject.toml, to fix building with tools that strictly implement PEP 517. PEP 517 requires the entry to be present, providing a fallback to the deprecated legacy setuptools backend ifsetup.pyis present, which is not the case here.Are there changes in behavior for the user?
Building from source distribution starts working for some users.
Related issue number
Checklist