Allow creating a connection with ufrag and pwd #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and enforce the length according to https://datatracker.ietf.org/doc/html/rfc5245#section-15.1 This allows implementing the peerconnection with a single set of local credentials in aiortc/aiortc#1229
borhandarabi
pushed a commit
to borhandarabi/aiortc
that referenced
this pull request
Mar 5, 2025
… with ufrag and pwd. PR: aiortc/aioice#82 (comment)
|
@jlaine ping |
lgrahl
approved these changes
Mar 18, 2025
Comment on lines
+320
to
+326
| if local_username is not None and len(local_username) not in range(4, 256): | ||
| raise ValueError("local ice username must satisfy 4*256ice-char") | ||
| #: Local username, automatically set to a random value. | ||
| self.local_username = random_string(4) | ||
| self.local_username = local_username or random_string(4) | ||
|
|
||
| if local_password is not None and len(local_password) not in range(22, 256): | ||
| raise ValueError("local ice password must satisfy 22*256ice-char") |
There was a problem hiding this comment.
len probably counts some non-ASCII symbols wrong with respect to the RFCs but why would you do that anyways, so I guess it's who cares in practice.
| #: Local password, automatically set to a random value. | ||
| self.local_password = random_string(22) | ||
| self.local_password = local_password or random_string(22) |
There was a problem hiding this comment.
or is a bit prone to error for an empty string even though this is impossible with above checks. A more explicit assignment in the conditional would be nicer but no strong opinion here.
|
Looks like the CI pipeline will need some work. I'm assuming it's because 3.7 is EOL. And we should probably add 3.12 - 3.14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and enforce the length according to
https://datatracker.ietf.org/doc/html/rfc5245#section-15.1
This allows implementing the peerconnection with a single set of local credentials in
aiortc/aiortc#1229