Skip to content

Commit

Permalink
Fix table replacement logic.
Browse files Browse the repository at this point in the history
  • Loading branch information
matthewwardrop committed Feb 12, 2019
1 parent dc20b79 commit 0e3b9bd
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions omniduct/databases/hiveserver2.py
Original file line number Diff line number Diff line change
Expand Up @@ -241,11 +241,11 @@ def _query_to_table(self, statement, table, if_exists, **kwargs):
elif if_exists == 'append':
raise NotImplementedError("Append operations have not been implemented for {}.".format(self.__class__.__name__))

statement = "CREATE TABLE {table} AS ({statement})".format(
statements.append("CREATE TABLE {table} AS ({statement})".format(
table=table,
statement=statement
)
return self.execute(statement, **kwargs)
))
return self.execute('\n'.join(statements), **kwargs)

@override
def _dataframe_to_table(
Expand Down
8 changes: 4 additions & 4 deletions omniduct/databases/presto.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,15 +175,15 @@ def _query_to_table(self, statement, table, if_exists, **kwargs):
if if_exists == 'fail' and self.table_exists(table):
raise RuntimeError("Table {} already exists!".format(table))
elif if_exists == 'replace':
statements.append('DROP TABLE IF EXISTS {};'.format(table))
statements.append('DROP TABLE IF EXISTS {};\n'.format(table))
elif if_exists == 'append':
raise NotImplementedError("Append operations have not been implemented for {}.".format(self.__class__.__name__))

statement = "CREATE TABLE {table} AS ({statement})".format(
statements.append("CREATE TABLE {table} AS ({statement})".format(
table=table,
statement=statement
)
return self.execute(statement, **kwargs)
))
return self.execute('\n'.join(statements), **kwargs)

@override
def _dataframe_to_table(self, df, table, if_exists='fail', **kwargs):
Expand Down

0 comments on commit 0e3b9bd

Please sign in to comment.