-
Notifications
You must be signed in to change notification settings - Fork 344
Auto-format README.md #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bachand, this fixed this markdown rendering issue in some Before
After
|
bachand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so great! Thanks @calda .
README.md
Outdated
| @@ -527,7 +530,7 @@ _You can enable the following settings in Xcode by running [this script](resourc | |||
|
|
|||
| </details> | |||
|
|
|||
| * <a id='trailing-commas'></a>(<a href='#trailing-commas'>link</a>) **Add a trailing comma after the last element of multi-line, multi-element comma-separated lists.* This includes arrays, dictionaries, function declarations, function calls, etc. Don't include a trailing comma if the list spans only a single line, or contains only a single element. [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#trailingCommas) | |||
| - <a id='trailing-commas'></a>(<a href='#trailing-commas'>link</a>) \*_Add a trailing comma after the last element of multi-line, multi-element comma-separated lists._ This includes arrays, dictionaries, function declarations, function calls, etc. Don't include a trailing comma if the list spans only a single line, or contains only a single element. [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#trailingCommas) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - <a id='trailing-commas'></a>(<a href='#trailing-commas'>link</a>) \*_Add a trailing comma after the last element of multi-line, multi-element comma-separated lists._ This includes arrays, dictionaries, function declarations, function calls, etc. Don't include a trailing comma if the list spans only a single line, or contains only a single element. [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#trailingCommas) | |
| - <a id='trailing-commas'></a>(<a href='#trailing-commas'>link</a>) **Add a trailing comma after the last element of multi-line, multi-element comma-separated lists.** This includes arrays, dictionaries, function declarations, function calls, etc. Don't include a trailing comma if the list spans only a single line, or contains only a single element. [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#trailingCommas) |
I think that this better matches the intention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -3381,7 +3397,6 @@ _You can enable the following settings in Xcode by running [this script](resourc | |||
| Most classes are never overridden, and composition is generally preferred over inheritance. | |||
|
|
|||
| If a class does need to be subclassed, use one of these approaches to indicate to the linter that the class should not be marked `final`: | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix!
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| bundler-cache: true | ||
| - uses: actions/setup-node@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So easy!
5a3a66b to
57aadef
Compare
7ee1b26 to
7fb972a
Compare



Inspired by #339, this PR adds linting and auto-formatting for our
README.md.I couldn't find a good Markdown auto-formatter in the Ruby ecosystem. Claude suggested using
prettiervianpx. This adds a dependency on Node, but at least installing Node is really easy (brew install node).The changes all seem like great improvements.