Fix issue with relative paths #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickHeiner
commented
Jul 5, 2022
| @@ -45,6 +45,68 @@ describe('migrate command', () => { | |||
| expect(exitCode).toBe(0); | |||
| }); | |||
|
|
|||
| describe('sources', () => { | |||
| it('Migrates project by using `sources`', async () => { | |||
There was a problem hiding this comment.
These tests could be DRY'd out with some other tests in the file, but some people prefer explicit and duplicative tests, so I left them as-is.
NickHeiner
commented
Jul 5, 2022
| expect(exitCode).toBe(0); | ||
| }); | ||
|
|
||
| it('Migrates project by using `sources` with an absolute path', async () => { |
There was a problem hiding this comment.
This test fails without the src change applied.
Rudeg
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #168.
Previously, absolute paths passed to
sourceswere handled incorrectly.