Nested ExpressionStatements Issue #144 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevents code duplication when nested nested statement expressions need are run though the `add-conversions` pluggin. - Previously add-conversions would generate two over lapping updates which `apply()` can not handle correctly.
- This fix handles nesting other stantments inside of a expression statement - Added additional test
|
If this approach seems correct, we can probably come up with a way to replace the recursive |
- Use a map to keep track of which nodes are expression statments - Check the map when deciding if we should replace a node
It should be fine.
I think it should be good to merge and you can test it with next release. Thank you for the contribution! |
Rudeg
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #144 ts-migrate will duplicate code when the add-conversion plug in is ran. This fix addresses the situation when there are nested expression statements that need to have
as anyapplied. Previously nested expression statements would generate multiple overlapping updates, which results in duplicate lines of code one with the conversions changes and one without.There a number of things I don't know which I would appreciate feedback/help with: