Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(mcp): route interactive Cloud API reads through the Config API #1090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix(mcp): route interactive Cloud API reads through the Config API #1090
Changes from 1 commit
92460598dd2ebfFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Filter out deselected catalog streams?
Could we require
entry["config"]["selected"]here, wdyt? This currently exposes all catalog streams asselected_streams, so disabled streams are reported byCloudConnection.stream_namesand the MCP connection description.Proposed fix
stream_names = [ entry["stream"]["name"] for entry in stream_entries - if isinstance(entry.get("stream"), Mapping) and entry["stream"].get("name") + if ( + isinstance(entry.get("stream"), Mapping) + and entry["stream"].get("name") + and isinstance(entry.get("config"), Mapping) + and entry["config"].get("selected") is True + ) ]Please add a deselected stream to the fixture and assert it is excluded.
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☑️ Resolved in 8dd2ebf. Agreed — filtered
stream_namesto selected streams. I use a_is_stream_selectedhelper rather than a strictconfig.selected is True: whenconfigis present I honorselected, but a missingconfigdefaults to selected (matching the platform default) so unusual payloads don't silently drop streams. Added a deselected stream to the fixture and assert it's excluded.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.