feat: add optional flag to install airbyte with auth disabled (#156)

Co-authored-by: Alex Buchanan <[email protected]>
airbytehq · Jan 22, 2025 · 25f9627 · 25f9627
1 parent 0414536
commit 25f9627
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/internal/cmd/local/helm/airbyte_values.go b/internal/cmd/local/helm/airbyte_values.go
@@ -15,14 +15,14 @@ type ValuesOpts struct {
 	InsecureCookies bool
 	TelemetryUser   string
 	ImagePullSecret string
+	DisableAuth     bool
 }
 
 func BuildAirbyteValues(ctx context.Context, opts ValuesOpts) (string, error) {
 	span := trace.SpanFromContext(ctx)
 
 	vals := []string{
 		"global.env_vars.AIRBYTE_INSTALLATION_ID=" + opts.TelemetryUser,
-		"global.auth.enabled=true",
 		"global.jobs.resources.limits.cpu=3",
 		"global.jobs.resources.limits.memory=4Gi",
 		"airbyte-bootloader.env_vars.PLATFORM_LOG_FORMAT=json",
@@ -34,6 +34,10 @@ func BuildAirbyteValues(ctx context.Context, opts ValuesOpts) (string, error) {
 		attribute.Bool("image-pull-secret", opts.ImagePullSecret != ""),
 	)
 
+	if !opts.DisableAuth {
+		vals = append(vals, "global.auth.enabled=true")
+	}
+
 	if opts.LowResourceMode {
 		vals = append(vals,
 			"server.env_vars.JOB_RESOURCE_VARIANT_OVERRIDE=lowresource",

diff --git a/internal/cmd/local/local_install.go b/internal/cmd/local/local_install.go
@@ -18,6 +18,7 @@ import (
 type InstallCmd struct {
 	Chart           string   `help:"Path to chart." xor:"chartver"`
 	ChartVersion    string   `help:"Version to install." xor:"chartver"`
+	DisableAuth     bool     `help:"Disable auth."`
 	DockerEmail     string   `group:"docker" help:"Docker email." env:"ABCTL_LOCAL_INSTALL_DOCKER_EMAIL"`
 	DockerPassword  string   `group:"docker" help:"Docker password." env:"ABCTL_LOCAL_INSTALL_DOCKER_PASSWORD"`
 	DockerServer    string   `group:"docker" default:"https://index.docker.io/v1/" help:"Docker server." env:"ABCTL_LOCAL_INSTALL_DOCKER_SERVER"`
@@ -68,6 +69,7 @@ func (i *InstallCmd) InstallOpts(ctx context.Context, user string) (*local.Insta
 		ValuesFile:      i.Values,
 		InsecureCookies: i.InsecureCookies,
 		LowResourceMode: i.LowResourceMode,
+		DisableAuth:     i.DisableAuth,
 	}
 
 	if opts.DockerAuth() {
@@ -166,9 +168,9 @@ func (i *InstallCmd) Run(ctx context.Context, provider k8s.Provider, telClient t
 			return fmt.Errorf("unable to initialize local command: %w", err)
 		}
 
-		spinner.UpdateText("Pulling images")		
+		spinner.UpdateText("Pulling images")
 		lc.PrepImages(ctx, cluster, opts)
-		
+
 		if err := lc.Install(ctx, opts); err != nil {
 			spinner.Fail("Unable to install Airbyte locally")
 			return err