feat: json logs from the bootloader #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-10
to
-17
| // 2024-09-10 20:16:24 WARN i.m.s.r.u.Loggers$Slf4JLogger(warn):299 - [273.... | ||
| var logRx = regexp.MustCompile(`^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2} \x1b\[(?:1;)?\d+m(?P<level>[A-Z]+)\x1b\[m (?P<msg>\S+ - .*)`) | ||
|
|
||
| type logLine struct { | ||
| msg string | ||
| level string | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we actually remove all of this? Isn't the PLATFORM_LOG_FORMAT envvar only going to work with certain newer versions of airbyte? Do we need to detect which version is running to know if the PLATFORM_LOG_FORMAT envvar is supported?
There was a problem hiding this comment.
The logRx wasn't really working already. I think shortly after I added that code, the platform tweaked the log format and the regexp stopped working.
colesnodgrass
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configures the bootloader to emit JSON formatted logs, and changes the log scanner in abctl to read JSON. This improves abctl's ability to recognize error logs from the bootloader and show them to the user.
The existing log scanner wasn't working anymore, and barely worked to begin with, so I removed it rather than keep it around to try to parse non-json logs.