refactor: only add streams with field transforms to updatedStreams #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutra-osmani
approved these changes
Nov 9, 2023
| // getStreamDiff only checks for differences in the stream's field name or field type | ||
| // but there are a number of reasons the streams might be different (such as a source-defined | ||
| // primary key or cursor changing). These should not be expressed as "stream updates". | ||
| UpdateStreamTransform streamTransform =getStreamDiff(streamOld, streamNew, stream); |
There was a problem hiding this comment.
linting will address the spacing.
There was a problem hiding this comment.
Thanks! Ran formatting + added a test for good measure.
|
solves ticket |
teallarson
changed the title
davinchia
approved these changes
Nov 13, 2023
@davinchia Are you saying the PR title should be "fix:" or just noting that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes airbytehq/airbyte#16092
BEFORE:
Previously, we would add all streams with changes to
uodatedStreams. However, within each stream, the only information we report back is (a) Field type changes or (b) Field addition/removal (name changes would be a removal/addition).This means that some types of changes, for instance a source changing its source-defined primary key or cursor, would add a stream to
updatedStreamsthat would have an empty array for itstransforms.AFTER:
These types of changes are not considered breaking. We don't need the information for the Platform's purposes, and we have not had a feature request to surface this kind of information in the diff modal.
We now only add streams with a relevant fieldTransform to updatedStreams.