Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: demonstrate pre-commit auto-formatting changes #271

Closed

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 25, 2025

This PR demonstrates the auto-formatting changes applied by our pre-commit hooks from #270.

Changes include:

  • Ruff formatting on Python files
  • TOML syntax validation (check-toml)
  • License header checks

Note: toml-sort has been removed to preserve semantic readability of TOML files.

This PR is stacked on #270 to show the effects of the pre-commit configuration.

Link to Devin run: https://app.devin.ai/sessions/84bdfd3518704af28a92318f28002810

devin-ai-integration bot and others added 7 commits January 25, 2025 03:59
This commit shows the auto-formatting changes applied by our pre-commit hooks:
- Ruff formatting on Python files
- TOML sorting on pyproject.toml
- License header checks

Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Copy link
Contributor Author

Original prompt:

@Devin - Create a pre-commit config for the CDK that matches the one used in the Airbyte monorepo. Except don't include Java or Kotlin tasks.

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

The toml-sort hook was removed as it could interfere with semantic readability of TOML files. The check-toml hook is retained for syntax validation.

Co-Authored-By: Aaron <AJ> Steers <[email protected]>
@devin-ai-integration devin-ai-integration bot changed the title test: demonstrate pre-commit auto-formatting changes test: demonstrate pre-commit auto-formatting changes (without toml-sort) Jan 25, 2025
@aaronsteers aaronsteers changed the base branch from main to devin/1737777544-add-pre-commit-cdk January 25, 2025 05:35
@aaronsteers aaronsteers changed the title test: demonstrate pre-commit auto-formatting changes (without toml-sort) chore: demonstrate pre-commit auto-formatting changes (without toml-sort) Jan 25, 2025
@github-actions github-actions bot added the chore label Jan 25, 2025
Base automatically changed from devin/1737777544-add-pre-commit-cdk to main January 29, 2025 03:51
@aaronsteers aaronsteers changed the title chore: demonstrate pre-commit auto-formatting changes (without toml-sort) chore: demonstrate pre-commit auto-formatting changes Jan 29, 2025
Copy link
Contributor Author

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant