Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pre-commit config for airbyte-python-cdk #270

Merged
merged 12 commits into from
Jan 29, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 25, 2025

Adds a new .pre-commit-config.yaml based on the Airbyte monorepo, excluding Java/Kotlin tasks.

This PR adds pre-commit configuration that:

  • Includes Ruff for Python linting and formatting (using repo-defined settings)
  • Includes Prettier for JSON/YAML formatting
  • Includes TOML syntax validation
  • Excludes all Java/Kotlin specific tasks
  • Configures appropriate file excludes for the CDK repository
  • Adds LICENSE_SHORT file for license header checks

All CI checks are passing and the configuration has been tested in this PR:

Link to Devin run: https://app.devin.ai/sessions/84bdfd3518704af28a92318f28002810

Copy link
Contributor Author

Original prompt:

@Devin - Create a pre-commit config for the CDK that matches the one used in the Airbyte monorepo. Except don't include Java or Kotlin tasks.

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions github-actions bot added the enhancement New feature or request label Jan 25, 2025
LICENSE_SHORT Outdated Show resolved Hide resolved
@aaronsteers aaronsteers merged commit c0ba13f into main Jan 29, 2025
19 checks passed
@aaronsteers aaronsteers deleted the devin/1737777544-add-pre-commit-cdk branch January 29, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant