-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use python 3.11 for connector tests in CI #313
Conversation
📝 WalkthroughWalkthroughThis pull request introduces two changes: one updates the Python version in the GitHub Actions workflow file used for connector tests from 3.10 to 3.11, and the other adds a debug print statement in the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as Caller
participant Source as ManifestDeclarativeSource.__init__()
Caller->>Source: Call __init__(manifest)
alt "type" key not present
Source->>Source: Print debug message
end
Source->>Caller: Return initialized object
Possibly related PRs
Suggested labels
Suggested reviewers
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for cleaning up my mess.
@aaronsteers the intent here is that we use the matrix to test the CDK itself, but switch to 3.11 to run airbyte-ci with 3.11.
What
We recently bumped airbyte-ci to use Python version 3.11, but the connector tests workflow for this repo still uses 3.10, leading to failures on connector CAT runs.
Summary by CodeRabbit