Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use python 3.11 for connector tests in CI #313

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

ChristoGrab
Copy link
Collaborator

@ChristoGrab ChristoGrab commented Feb 4, 2025

What

We recently bumped airbyte-ci to use Python version 3.11, but the connector tests workflow for this repo still uses 3.10, leading to failures on connector CAT runs.

Summary by CodeRabbit

  • Chores
    • Updated the automated testing environment to use Python 3.11 for consistency and improved support.

@github-actions github-actions bot added the chore label Feb 4, 2025
@ChristoGrab ChristoGrab marked this pull request as ready for review February 4, 2025 19:19
Copy link
Contributor

coderabbitai bot commented Feb 4, 2025

📝 Walkthrough

Walkthrough

This pull request introduces two changes: one updates the Python version in the GitHub Actions workflow file used for connector tests from 3.10 to 3.11, and the other adds a debug print statement in the __init__ method of the ManifestDeclarativeSource class to indicate when the "type" key is missing from the manifest.

Changes

File Changes
.github/.../connector-tests.yml Updated Python version from 3.10 to 3.11 for the connectors_ci job in the CI workflow.
airbyte_cdk/.../manifest_declarative_source.py Inserted a debug print statement in the __init__ method when the "type" key is missing.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as Caller
    participant Source as ManifestDeclarativeSource.__init__()
    Caller->>Source: Call __init__(manifest)
    alt "type" key not present
        Source->>Source: Print debug message
    end
    Source->>Caller: Return initialized object
Loading

Possibly related PRs

Suggested labels

ci

Suggested reviewers

  • aaronsteers – would you like to review this? wdyt?

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef97304 and 936fe6c.

📒 Files selected for processing (2)
  • .github/workflows/connector-tests.yml (1 hunks)
  • airbyte_cdk/sources/declarative/manifest_declarative_source.py (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • airbyte_cdk/sources/declarative/manifest_declarative_source.py
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Check: 'source-shopify' (skip=false)
  • GitHub Check: Pytest (All, Python 3.11, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.10, Ubuntu)
🔇 Additional comments (1)
.github/workflows/connector-tests.yml (1)

131-131: Transition to Python 3.11 in the testing workflow:
The updated python-version: "3.11" looks appropriate to align with the upgraded airbyte-ci environment. Could you please confirm that all subsequent steps and dependencies in the workflow have been validated for compatibility with Python 3.11? wdyt?


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for cleaning up my mess.

@aaronsteers the intent here is that we use the matrix to test the CDK itself, but switch to 3.11 to run airbyte-ci with 3.11.

@ChristoGrab ChristoGrab enabled auto-merge (squash) February 4, 2025 19:29
@ChristoGrab ChristoGrab merged commit 979598c into main Feb 4, 2025
20 checks passed
@ChristoGrab ChristoGrab deleted the christo/connector-tests-workflow-fix branch February 4, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants