Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removes stream_state interpolation from CDK #320

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pnilan
Copy link
Contributor

@pnilan pnilan commented Feb 6, 2025

What

  • Removes stream_state interpolation from interpolation_context in declarative_component_schema
    • Removal updates the available context in Builder Ui
  • No longer passes stream_state to the HttpRequester, AddFields, and RequestOptionsProvider, and RecordFilter components.
    • This change makes stream_state inaccessible as a interpolated variable.
  • Updates JinjaInterpolation class to raise AirbyteTracedException when connector attempts to evaluate a jinja expression that contains stream_state.
  • Removes helper methods used to prevent streams to be DefaultStreams (concurrent) if stream_state interpolation was used.
  • Major version bump w/ change documented in CDK Migration Guide
  • Updates tests, were needed

Recommended Reading Order

  1. declarative_component_schema.yaml
  2. http_requester.py
  3. interpolated_requests_input_provider.py
  4. interpolated_nested_request_input_provider.py
  5. add_fields.py
  6. interpolated_requests_options_provider.py
  7. jinja.py
  8. cdk_migrations.md

Summary by CodeRabbit

  • New Features

    • Improved error handling for interpolation inputs now provides clear messages when unsupported variables are used, with recommendations for alternatives.
  • Refactor

    • Enhanced component formatting for better clarity and consistency.
    • Streamlined request and transformation interfaces by removing legacy state parameters, simplifying usage and reducing complexity.

@github-actions github-actions bot added the enhancement New feature or request label Feb 6, 2025

This comment was marked as off-topic.

coderabbitai[bot]

This comment was marked as outdated.

@pnilan pnilan changed the title feat(removes stream_state interpolation) feat: Removes stream_state interpolation from CDK Feb 6, 2025
coderabbitai[bot]

This comment was marked as resolved.

@brianjlai brianjlai self-requested a review February 11, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant