Skip to content

ci: add connector-test-summary job #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Apr 16, 2025

This allows us to set a CI "required" condition on the summary, meaning fail if any item in the matrix fails, but don't penalize for skipped items.

Summary by CodeRabbit

  • Chores
    • Added a summary job to the workflow to confirm successful completion of all connector tests.

@Copilot Copilot AI review requested due to automatic review settings April 16, 2025 19:25
@github-actions github-actions bot added the ci label Apr 16, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Copy link
Contributor

coderabbitai bot commented Apr 16, 2025

📝 Walkthrough

Walkthrough

A new job named connectors_ci_summary has been added to the GitHub Actions workflow file .github/workflows/connector-tests.yml. This job is configured to run after the completion of the existing connectors_ci matrix job and executes a single step that echoes a success message. The purpose of this addition is to provide a consolidated success indicator for the matrix job, especially useful when some matrix entries may be skipped.

Changes

File(s) Change Summary
.github/workflows/connector-tests.yml Added a connectors_ci_summary job dependent on connectors_ci, running on Ubuntu 22.04, with a step to echo a success message.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub Actions
    participant connectors_ci (matrix job)
    participant connectors_ci_summary

    GitHub Actions->>connectors_ci: Start matrix job
    connectors_ci-->>GitHub Actions: Complete all matrix runs
    GitHub Actions->>connectors_ci_summary: Start summary job (after connectors_ci)
    connectors_ci_summary-->>GitHub Actions: Echo success message
Loading

Possibly related PRs

Suggested reviewers

  • bnchrch (Would you like to take a look at this update to the workflow, wdyt?)

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6358ef4 and b4d4440.

📒 Files selected for processing (1)
  • .github/workflows/connector-tests.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/connector-tests.yml
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Pytest (Fast)
  • GitHub Check: SDM Docker Image Build

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/connector-tests.yml (1)

237-240: Fix minor typo in comments
I noticed the word “preceeding” in the job description is misspelled; it should be “preceding.” Would you mind updating that? wdyt?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf998bd and 6358ef4.

📒 Files selected for processing (1)
  • .github/workflows/connector-tests.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Pytest (Fast)
  • GitHub Check: SDM Docker Image Build
🔇 Additional comments (2)
.github/workflows/connector-tests.yml (2)

241-244: Job configuration looks good!
The connectors_ci_summary job correctly depends on connectors_ci and runs on the expected runner, providing a single required check for the matrix outcome.


245-247: Summary step is clear and concise
The step echoes a success message when the matrix passes—nice and simple!

@aaronsteers
Copy link
Contributor Author

Closing because we do not want to make these required. In future, we can re-open/revise if it is helpful to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant