-
Notifications
You must be signed in to change notification settings - Fork 18
ci: add connector-test-summary job #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add connector-test-summary job #488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
📝 WalkthroughWalkthroughA new job named Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant connectors_ci (matrix job)
participant connectors_ci_summary
GitHub Actions->>connectors_ci: Start matrix job
connectors_ci-->>GitHub Actions: Complete all matrix runs
GitHub Actions->>connectors_ci_summary: Start summary job (after connectors_ci)
connectors_ci_summary-->>GitHub Actions: Echo success message
Possibly related PRs
Suggested reviewers
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/connector-tests.yml (1)
237-240
: Fix minor typo in comments
I noticed the word “preceeding” in the job description is misspelled; it should be “preceding.” Would you mind updating that? wdyt?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/connector-tests.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Pytest (Fast)
- GitHub Check: SDM Docker Image Build
🔇 Additional comments (2)
.github/workflows/connector-tests.yml (2)
241-244
: Job configuration looks good!
Theconnectors_ci_summary
job correctly depends onconnectors_ci
and runs on the expected runner, providing a single required check for the matrix outcome.
245-247
: Summary step is clear and concise
The step echoes a success message when the matrix passes—nice and simple!
Co-authored-by: Copilot <[email protected]>
Closing because we do not want to make these required. In future, we can re-open/revise if it is helpful to do so. |
This allows us to set a CI "required" condition on the summary, meaning fail if any item in the matrix fails, but don't penalize for skipped items.
Summary by CodeRabbit