feat: Update protocol version #601
Conversation
📝 WalkthroughWalkthroughThe dependency version for Changes
If you'd like, I can suggest running your test suite to ensure compatibility with the new dependency version—wdyt? Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
33-33: Consider adding a CHANGELOG entry
Could we add a brief note inCHANGELOG.mdto document this protocol version update for future reference? Wdyt?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (17)
- GitHub Check: Check: source-shopify
- GitHub Check: Check: source-pokeapi
- GitHub Check: Check: source-amplitude
- GitHub Check: Check: source-intercom
- GitHub Check: Check: source-hardcoded-records
- GitHub Check: SDM Docker Image Build
- GitHub Check: MyPy Check
- GitHub Check: Build and Inspect Python Package
- GitHub Check: Pytest (Fast)
- GitHub Check: Ruff Format Check
- GitHub Check: preview_docs
- GitHub Check: Ruff Lint Check
- GitHub Check: Dependency Analysis with Deptry
- GitHub Check: Pytest (All, Python 3.10, Ubuntu)
- GitHub Check: Pytest (All, Python 3.11, Ubuntu)
- GitHub Check: Analyze (actions)
- GitHub Check: Analyze (python)
🔇 Additional comments (1)
pyproject.toml (1)
33-33: Dependency bump validated
The updated constraint^0.17.1correctly aligns with the new Data Activation destination sync modes in the protocol, and all existing tests remain compatible.
What
For Data Activation, we added a couple of destination sync modes. We expect the sources to fail the parsing of the configured catalog if we don't update the protocol version
How
Update the protocol version. I checked for specific usages of DestinationSyncMode and could only find vector-db stuff (which won't expose the new sync modes as part of their spec so it should be fine) and tests
Summary by CodeRabbit