fix: Manual tests and bug fix for static schema discover (PR #559)

[devin-ai-integration]

Manual Tests and Bug Fixes for PR #559: Config-Free Discover for Static Schema Connectors

Summary

This PR provides comprehensive manual testing for PR #559 (unprivileged and config-free discover for declarative static schemas) and implements critical bug fixes discovered during testing. The main contribution is proving that the feature works for static schema connectors while identifying remaining edge cases.

Key Changes:

• 🐛 Fixed TypeError in ManifestDeclarativeSource._uses_dynamic_schema_loader() preventing discover from starting
• 🐛 Fixed MyPy error in source_base.py test infrastructure
• 🐛 Fixed Pydantic frozen instance error in connector_base.py preventing PyTest execution
• 📋 Comprehensive test documentation with methodology and results for 4 representative connectors

Test Results:

• ✅ source-pokeapi (static schema): Config-free discover works perfectly
• ❌ source-datascope (static schema): Core bug fixed, but fails on datetime parsing
• ✅ source-google-sheets (dynamic schema): Correctly requires config (expected)
• ✅ source-google-search-console (dynamic schema): Correctly fails without config (expected)

Review & Testing Checklist for Human

🔴 High Priority (3 items):

• Test with additional static schema connectors - Only 2 static schema connectors were tested. Verify the fix works with a broader set to ensure general compatibility.
• Validate empty config parameter fix - The core fix in _uses_dynamic_schema_loader() adds empty_config: Dict[str, Any] = {}. Verify this doesn't break existing connectors that expect populated configs.
• Review datetime parsing limitation - source-datascope still fails with ValueError: time data '' does not match format '%d/%m/%Y %H:%M'. Determine if this edge case should block the feature or be addressed separately.

🟡 Medium Priority (2 items):

• Verify CLI vs Docker testing equivalence - Testing used poetry run source-declarative-manifest CLI approach instead of Docker images. Confirm this accurately reflects production behavior.
• Review Pydantic model changes - The frozen instance fix changes how ConnectorTestScenario models are constructed. Verify this doesn't affect other test scenarios.

---

Diagram

%%{ init : { "theme" : "default" }}%%
graph TD
    subgraph "Core CDK Files"
        A["airbyte_cdk/sources/declarative/<br/>manifest_declarative_source.py"]:::major-edit
        B["airbyte_cdk/test/standard_tests/<br/>source_base.py"]:::minor-edit  
        C["airbyte_cdk/test/standard_tests/<br/>connector_base.py"]:::major-edit
    end
    
    subgraph "Test Connectors"
        D["source-pokeapi<br/>(static schema)"]:::context
        E["source-datascope<br/>(static schema)"]:::context
        F["source-google-sheets<br/>(dynamic schema)"]:::context
        G["source-google-search-console<br/>(dynamic schema)"]:::context
    end
    
    subgraph "Documentation"
        H["manual_test_plan_pr559.md"]:::major-edit
    end
    
    A -->|"Fixed _uses_dynamic_schema_loader()<br/>TypeError"| D
    A -->|"Fixed _uses_dynamic_schema_loader()<br/>TypeError"| E
    B -->|"Fixed MyPy error"| C
    C -->|"Fixed Pydantic frozen<br/>instance error"| H
    D -->|"✅ SUCCESS"| H
    E -->|"❌ Datetime parsing error"| H
    F -->|"✅ Correctly requires config"| H
    G -->|"✅ Correctly fails"| H
    
    subgraph Legend
        L1[Major Edit]:::major-edit
        L2[Minor Edit]:::minor-edit  
        L3[Context/No Edit]:::context
    end
    
    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#87CEEB
    classDef context fill:#FFFFFF

Loading

Notes

• Session Details: Requested by @aaronsteers, Devin session: https://app.devin.ai/sessions/0ec763a8dfb84a66a7a211fc01aa6168
• Stacked PR: This PR targets PR feat: Add unprivileged and config-free discover for declarative static schemas #559 (aj/feat/unprivileged-discover-for-declarative-static-schemas) rather than main
• Feature Status: Core functionality is working but needs additional work for edge cases like empty datetime values
• Testing Methodology: Used CLI approach (poetry run source-declarative-manifest discover) to bypass Docker image building issues and directly test CDK changes
• CI Status: Ignored per user request - focus was on local testing and validation

[devin-ai-integration]

Original prompt from AJ Steers:

@Devin - Help me by designing some manual tests for this PR. <https://github.com/airbytehq/airbyte-python-cdk/pull/559>

Start by selecting one two manifest-only connectors each that do or don't use dynamic schemas. We should be able to use `airbyte-cdk image build` (prefixed by poetry run) and running 'discover' on each built image. If working as expected the sources using dynamic schemas should fail 'discover' and those without should succeed.

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring

[github-actions]

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1752808596-manual-tests-static-schema-discover#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1752808596-manual-tests-static-schema-discover

Helpful Resources

• CDK API Reference

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

• /autofix - Fixes most formatting and linting issues
• /poetry-lock - Updates poetry.lock file
• /test - Runs connector tests with the updated CDK
• /poe <command> - Runs any poe command in the CDK environment

📝 Edit this welcome message.

[github-actions]

PyTest Results (Fast)

3 698 tests  +3 697   3 687 ✅ +3 687   6m 27s ⏱️ + 6m 25s
    1 suites ±    0      11 💤 +   11 
    1 files   ±    0       0 ❌ ±    0 

Results for commit 3798fb4. ± Comparison against base commit b956a30.

♻️ This comment has been updated with latest results.

[github-actions]

PyTest Results (Full)

3 701 tests  +3 699   3 690 ✅ +3 690   18m 22s ⏱️ + 18m 8s
    1 suites ±    0      11 💤 +   11 
    1 files   ±    0       0 ❌ ±    0 

Results for commit 3798fb4. ± Comparison against base commit b956a30.

♻️ This comment has been updated with latest results.