Skip to content

fix: hubspot property chunking #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2025
Merged

fix: hubspot property chunking #797

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2de3d4
fix hubspot property chunking
Oct 15, 2025
0bf488e
emit record when not chunking
Oct 15, 2025
69a490b
Auto-fix lint and format issues
Oct 15, 2025
5816cd8
adding test for query properties without propertychunking
Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions airbyte_cdk/sources/declarative/retrievers/simple_retriever.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,10 +384,7 @@ def _read_pages(

response = None
try:
if (
self.additional_query_properties
and self.additional_query_properties.property_chunking
):
if self.additional_query_properties:
for properties in self.additional_query_properties.get_request_property_chunks(
stream_slice=stream_slice
):
Expand All @@ -401,15 +398,21 @@ def _read_pages(
)

for current_record in records_generator_fn(response):
merge_key = (
self.additional_query_properties.property_chunking.get_merge_key(
current_record
if self.additional_query_properties.property_chunking:
merge_key = (
self.additional_query_properties.property_chunking.get_merge_key(
current_record
)
)
)
if merge_key:
_deep_merge(merged_records[merge_key], current_record)
if merge_key:
_deep_merge(merged_records[merge_key], current_record)
else:
# We should still emit records even if the record did not have a merge key
pagination_tracker.observe(current_record)
last_page_size += 1
last_record = current_record
yield current_record
else:
# We should still emit records even if the record did not have a merge key
pagination_tracker.observe(current_record)
last_page_size += 1
last_record = current_record
Expand Down
Loading