feat(destination-mssql-v2,bulk-cdk): add ssl restriction (#52147)

Co-authored-by: Octavia Squidington III <[email protected]>
airbytehq · Jan 30, 2025 · 926f13d · 926f13d
1 parent 2858945
commit 926f13d
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/.../core/load/src/main/kotlin/io/airbyte/cdk/load/command/DestinationConfigurationFactory.kt b/.../core/load/src/main/kotlin/io/airbyte/cdk/load/command/DestinationConfigurationFactory.kt
@@ -5,6 +5,7 @@
 package io.airbyte.cdk.load.command
 
 import io.airbyte.cdk.ConfigErrorException
+import io.airbyte.cdk.ConnectorErrorException
 import io.airbyte.cdk.command.ConfigurationSpecification
 
 interface DestinationConfigurationFactory<
@@ -15,6 +16,8 @@ interface DestinationConfigurationFactory<
     fun make(spec: I): O =
         try {
             makeWithoutExceptionHandling(spec)
+        } catch (e: ConnectorErrorException) {
+            throw e
         } catch (e: Exception) {
             // Wrap NPEs (mostly) in ConfigErrorException.
             throw ConfigErrorException("Failed to build ConnectorConfiguration.", e)

diff --git a/...src/main/kotlin/io/airbyte/integrations/destination/mssql/v2/config/MSSQLConfiguration.kt b/...src/main/kotlin/io/airbyte/integrations/destination/mssql/v2/config/MSSQLConfiguration.kt
@@ -4,6 +4,8 @@
 
 package io.airbyte.integrations.destination.mssql.v2.config
 
+import io.airbyte.cdk.ConfigErrorException
+import io.airbyte.cdk.command.FeatureFlag
 import io.airbyte.cdk.load.command.DestinationConfiguration
 import io.airbyte.cdk.load.command.DestinationConfigurationFactory
 import io.micronaut.context.annotation.Factory
@@ -24,9 +26,18 @@ data class MSSQLConfiguration(
 }
 
 @Singleton
-class MSSQLConfigurationFactory :
+class MSSQLConfigurationFactory(private val featureFlags: Set<FeatureFlag>) :
     DestinationConfigurationFactory<MSSQLSpecification, MSSQLConfiguration> {
+
+    constructor() : this(emptySet())
+
     override fun makeWithoutExceptionHandling(pojo: MSSQLSpecification): MSSQLConfiguration {
+        if (
+            pojo.sslMethod is Unencrypted &&
+                featureFlags.contains(FeatureFlag.AIRBYTE_CLOUD_DEPLOYMENT)
+        ) {
+            throw ConfigErrorException("Connection from Airbyte Cloud requires SSL encryption")
+        }
         return makeWithOverrides(spec = pojo)
     }
 

diff --git a/...rc/test-integration/kotlin/io/airbyte/integrations/destination/mssql/v2/MSSQLCheckTest.kt b/...rc/test-integration/kotlin/io/airbyte/integrations/destination/mssql/v2/MSSQLCheckTest.kt
@@ -4,6 +4,7 @@
 
 package io.airbyte.integrations.destination.mssql.v2
 
+import io.airbyte.cdk.command.FeatureFlag
 import io.airbyte.cdk.load.check.CheckIntegrationTest
 import io.airbyte.cdk.load.check.CheckTestConfig
 import io.airbyte.integrations.destination.mssql.v2.config.MSSQLSpecification
@@ -15,9 +16,17 @@ internal class MSSQLCheckTest :
             listOf(
                 CheckTestConfig(MSSQLTestConfigUtil.getConfigPath("check/valid.json")),
                 CheckTestConfig(MSSQLTestConfigUtil.getConfigPath("check/valid-ssl-trust.json")),
+                CheckTestConfig(
+                    MSSQLTestConfigUtil.getConfigPath("check/valid-ssl-trust.json"),
+                    setOf(FeatureFlag.AIRBYTE_CLOUD_DEPLOYMENT),
+                ),
             ),
         failConfigFilenamesAndFailureReasons =
             mapOf(
+                CheckTestConfig(
+                    MSSQLTestConfigUtil.getConfigPath("check/valid.json"),
+                    setOf(FeatureFlag.AIRBYTE_CLOUD_DEPLOYMENT),
+                ) to "Airbyte Cloud requires SSL encryption".toPattern(),
                 CheckTestConfig(
                     MSSQLTestConfigUtil.getConfigPath("check/fail-internal-schema-invalid.json")
                 ) to "\"iamnotthere\" either does not exist".toPattern(),