-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source-xero: enable on Cloud and disable OAuth. #42126
Comments
Unfortunately, Xero has custom components, so it's not as easy as opening it in the builder ;( |
Referencing PR: #42128 |
@bnchrch @btkcodedev here instead of disabling OAuth we should add custom OAuth support once @bazarnov 's PR lands in Connector Builder. We should make the source manifest-only first if it is not already. |
Hey! Now that we have OAuth support in Buidler that is coming very soon, I would love to recover source-xero OAuth support on Cloud with custom creds. Is this still needed? @bazarnov @chandlerprall @btkcodedev what should we do here, rebase the PR and change the authenticator spec to include fields and scopes? How should BTK go about it? Wait for the OAUth in Builder support? |
It's possible definitely, having this Xero OAuthFlow as an The approximate spec would look like this: {
"oauth_connector_input_specification": {
"type": "object",
"additionalProperties": false,
"properties": {
"consent_url": "https://login.xero.com/identity/connect/authorize?{{client_id_param}}&{{redirect_uri_param}}&response_type=code&{{scope_param}}&{{state_param}}",
"scope": "accounting.attachments.read accounting.budgets.read accounting.contacts.read accounting.journals.read accounting.reports.read accounting.reports.tenninetynine.read accounting.settings.read accounting.transactions.read assets.read offline_access",
"access_token_url": "https://identity.xero.com/connect/token?grant_type=authorization_code&{{auth_code_param}}&{{redirect_uri_param}}",
"access_token_headers": {
"Content-Type": "application/x-www-form-urlencoded",
"Authorization": "Basic {{ {{client_id_value}}:{{client_secret_value}} | base64Encoder }}"
},
"extract_output": ["access_token", "refresh_token", "expires_in"]
}
}
}
We can have it already if we remove the The plan is next:
Alternatively:
|
Following the |
Ok Cool, I'll wait for the OAuth support in cloud for proceeding this. |
@topefolorunso just moved Xero to manifest-only! @btkcodedev mind giving this over to @topefolorunso? Tope, look at the manual Baz posted above. |
@topefolorunso you're up |
On it! @natikgadzhi. Thanks man @btkcodedev, good job so far. |
Problem
Souce-Xero limits the number of OAuth users Airbyte's app can have, and we're treading water in securing a partnership.
We already have the selective authenticator in
source-xero
source code, but we know that on Cloud, we want to restrict new OAuth users.We do want source-xero to be available on Cloud, though. @nataliekwong mentioned a lot of folks are running it in the Builder as a workaround.
Solution
Remove OAuth authenticator, leave the bearer authenticator only, and release a new version, with a breaking change.
The text was updated successfully, but these errors were encountered: