-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨🚨Source Xero: Temporarily remove OAuth support due to user limit restrictions #42128
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly great! Let's figure out wording, see if tests pass, and ship.
@@ -7,7 +7,7 @@ acceptance_tests: | |||
tests: | |||
- spec_path: "source_xero/spec.yaml" | |||
backward_compatibility_tests_config: | |||
disable_for_version: "0.2.5" | |||
disable_for_version: "2.0.0" # Disabling Oauth support due to limit restriction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea if this should be 3.0 or 2.0, but hope this works ;)
remoteRegistries: | ||
pypi: | ||
enabled: true | ||
packageName: airbyte-source-xero | ||
releases: | ||
breakingChanges: | ||
3.0.0: | ||
upgradeDeadline: "2024-08-30" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generous, and alright with me.
3.0.0: | ||
upgradeDeadline: "2024-08-30" | ||
message: | ||
Due to limitations on the number of OAuth users permitted for the Airbyte application, OAuth support has been disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the right wording, but want to make this look nicer. /cc @katmarkham
Hey both, just saw this. I agree that OAuth is limited to one application only, but having only bearer strategy beats the purpose of consistent synchronization - since you could only do it once and then you'll need to generate a refresh token (not supported yet with the bearer token, at least last I checked) Until we figure that piece out, the xero connector will be limited to one sync that should be triggered manually after generating a new token |
Agreed. We're working on allowing full OAuth flow in Builder, but it's not yet ready, and if Xero has single use / refresh tokens that won't refresh if we provide the token in config, that's not great 👀 |
Yes, happy to contribute on this if needed! |
So, wait up, what's stopping us from using OAuth authenticator and setting up correct refresh token paths? /cc @btkcodedev |
Already xero has bearer and oauth strategies, |
Closes #42126
What
OAuth support for the source-Xero connector has been removed due to restrictions on the number of OAuth users allowed for the Airbyte application.
How
Removed the OAuth authenticator, retained only the bearer authenticator, and released a new version with a breaking change.
Review guide
manifest.yaml
metadata.yaml
xero-migrations.md
User Impact
*Breaking Change