-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Source Youtube Analytics - Migrate Python CDK to Low-code CDK to Manifest-only #42838
base: master
Are you sure you want to change the base?
Conversation
…pe/migrate-youtube-analytics-lowcode
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit 3dbdad9.
/format-fix
|
…pe/migrate-youtube-analytics-lowcode
…ub.com/airbytehq/airbyte into tope/migrate-youtube-analytics-lowcode
…pe/migrate-youtube-analytics-lowcode
@natikgadzhi Can you confirm the test credentials are valid. ps: I passed the check command in local |
Ummm the screenshot is failing check. I'll run regression tests once basic CATs pass |
I think it's an issue with the test credentials. I tested with mine and check passed |
Ok we sort of have a youtube channel, let me try and update the creds. |
Kicked-off a pre-release build, will try it out and report back. Didn't have time yet. |
With the pre-release build, on my personal account on cloud, I get a check error:
It maybe because of the lack of data in my channel, but let me try the current version to verify. UPD: the current version fails with @DanyloGL can you help test this to get this over the finish line? |
…ub.com/airbytehq/airbyte into tope/migrate-youtube-analytics-lowcode
…pe/migrate-youtube-analytics-lowcode
/format-fix
|
…pe/migrate-youtube-analytics-lowcode
…ub.com/airbytehq/airbyte into tope/migrate-youtube-analytics-lowcode
/format-fix
|
…pe/migrate-youtube-analytics-lowcode
…ub.com/airbytehq/airbyte into tope/migrate-youtube-analytics-lowcode
/format-fix
|
…pe/migrate-youtube-analytics-lowcode
@natikgadzhi I need help here implementing the async retriever please |
Converting this would indeed be a very big win. @lazebnyi or @darynaishchenko, would any of you find time this week to take a good look into this and record a loom + provide examples to @topefolorunso on how to impolement async retrievers? Getting another big connector to manifest-only would be lovely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to implement AsyncRetriever
and an error handler in the manifest. Everything else looks good.
|
||
|
||
@dataclass | ||
class YoutubeAnalyticsErrorHandler(DefaultErrorHandler): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error_handler:
type: DefaultErrorHandler
backoff_strategies:
- type: ConstantBackoff
backoff_time_in_seconds: 30
response_filters:
type: HttpResponseFilter
action: FAIL
http_codes:
- 429
predicate: >-
{{response.get("error", {}).get("details", [])[0].get("reason") == "RATE_LIMIT_EXCEEDED" and response.get("error", {}).get("details", [])[0].get("metadata", {}).get("quota_limit") == "FreeQuotaRequestsPerDayPerProject"}}
error_message: >-
{{ "Exceeded daily quota: " + response.get("error", {}).get("details", [])[0].get('metadata', {}).get('quota_limit_value')} + " reqs/day" }}
It is better to describe error handler in the manifest instead have a custom component.
|
||
|
||
@dataclass | ||
class CreationRequester(HttpRequester): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this behavior you could use AsyncRetirever
to avoid custom component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried implementing the async retriever here @lazebnyi . This custom component is only a component of the async retriever to the best of my understanding. I will watch the loom and be back with questions 🤞🏼
What
Migrate Youtube Analytics Python CDK to Low-code CDK to Manifest-only fixes https://github.com/airbytehq/airbyte-internal-issues/issues/8865
How
Developed using UI Builder and the Low-code CDK
Recommended reading order
manifest.yaml
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.
If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Actions
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.